Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Able to add candidates with invalid format of id and email ( Form Control ) #28

Open
sarthakmalik0810 opened this issue May 14, 2021 · 8 comments
Labels
Form Control and/or Alert Form Control and/or Alert

Comments

@sarthakmalik0810
Copy link

Consider adding these checks. Also give suitable errors.

@abhpd
Copy link
Contributor

abhpd commented May 17, 2021

We already have a check in-place for if the fields are empty.
@sarthakmalik0810 Can you elaborate on how you encountered this?

@sarthakmalik0810
Copy link
Author

@abhpd I believe there's no check for strings with spaces. Shall I add this check?

@sarthakmalik0810
Copy link
Author

Also do you plan to add material-ui?

@abhpd abhpd changed the title Able to add candidates with empty name, empty id and empty candidate id Able to add candidates with invalid format of id and email ( Form Control ) May 18, 2021
@abhpd
Copy link
Contributor

abhpd commented May 18, 2021

@abhpd I believe there's no check for strings with spaces. Shall I add this check?

Assigning it to you.

@abhpd
Copy link
Contributor

abhpd commented May 18, 2021

Also do you plan to add material-ui?

I think implementing meterial-ui will need a redesign of the UI/UX. I think the better approach will be to Create a new completely responsive interface design with material-UI.

@19BCS1114
Copy link
Contributor

@abhpd different institutes have different ids, so we cannot generally define what an invalid format for 'id' would be.

@abhpd
Copy link
Contributor

abhpd commented May 18, 2021

@abhpd different institutes have different ids, so we cannot generally define what an invalid format for 'id' would be.

It will be a simple check to confirm a non-spaced series or letter/numbers/special characters. I think this will cover most of the university ids

@abhpd
Copy link
Contributor

abhpd commented May 19, 2021

#30 Partially solves the issue of empty or spaced string but still, we need a check for valid email and ID format

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Form Control and/or Alert Form Control and/or Alert
Projects
None yet
Development

No branches or pull requests

3 participants