Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redis-likes for Session Storage? #367

Open
jaidetree opened this issue Dec 9, 2024 · 3 comments
Open

Redis-likes for Session Storage? #367

jaidetree opened this issue Dec 9, 2024 · 3 comments

Comments

@jaidetree
Copy link

This framework looks very impressive! I noticed in the docs the session backends include memory, cookies, or sql. Was curious if you'd be open to a PR that extends a redis (or redis-like) session store?

@aantron
Copy link
Owner

aantron commented Dec 10, 2024

Could it be written as a library, which we could link to from the Dream repo/sites? The reason I am asking is because I am concerned about picking up a dependency, or else an awkward API with extra callbacks to bind it to a dependency dynamically. If there is any obstacle to writing a redis session backend as a library, I think we should fix that and I would be very open to a PR to that end.

@jaidetree
Copy link
Author

I see, the memory, cookie, and db backends reuse resources already included in the framework whereas this would require at least a redis client library which may not get used by anything else. That said, it can be useful for async worker queues but understandably not a high priority.

A separate library with a link in the docs works for me as a staring point.

I'll start drafting that library. My plan was to match the other storage module APIs and use a popular\common redis client library so not expecting much chaos there, but will see how it goes.

If I do run into any barriers from the framework design I'll create issues to make sure it's something that needs to be addressed and to ensure we're on the same page for how to solve it.

@aantron
Copy link
Owner

aantron commented Dec 11, 2024

Great, looking forward to that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants