Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support retries when execution rpc fails in wasm #407

Open
ncitron opened this issue Oct 26, 2024 · 1 comment · May be fixed by #481
Open

feat: support retries when execution rpc fails in wasm #407

ncitron opened this issue Oct 26, 2024 · 1 comment · May be fixed by #481
Labels
execution Execution-related work. feat New feature or request

Comments

@ncitron
Copy link
Collaborator

ncitron commented Oct 26, 2024

We had to disable Alloy's rate limit retry mechanism when compiling to wasm in core/execution/rpc/http_rpc.rs because it doesn't seem to compile properly. This means if the external RPC fails the whole helios request will error, which we don't want. Implement some sort of retry mechanism that works in wasm or find out how to make Alloy's work properly (using alloy's is the preference). We should also be intelligent about only retrying things that we think might be resolved (rate limits, connection errors) as opposed to something else.

@ncitron ncitron added feat New feature or request execution Execution-related work. labels Oct 26, 2024
@eshaan7
Copy link
Contributor

eshaan7 commented Nov 8, 2024

I think this may be due to being on quite an old version of alloy 0.2.1 while the current latest is 0.6.2.

For example, the below diff in the file that defines RetryBackoffLayer makes me think the newer version supports Wasm:

#[cfg(target_arch = "wasm32")]
use wasmtimer::tokio::sleep;

#[cfg(not(target_arch = "wasm32"))]
use tokio::time::sleep;

-- link

However, not able to confirm this because updating to latest version of alloy breaks a lot of things elsewhere in the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execution Execution-related work. feat New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants