Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): Limit parallel jobs launched by the crates workflow #7754

Merged
merged 1 commit into from
Oct 19, 2023
Merged

fix(ci): Limit parallel jobs launched by the crates workflow #7754

merged 1 commit into from
Oct 19, 2023

Conversation

teor2345
Copy link
Contributor

Motivation

Some workflows launch a lot of jobs, but those jobs are fast. So they can wait until later to run.

This also avoids hitting some rate limits.

Close #6702

Depends-On: #7616

Solution

Limit the number of parallel crate build jobs to avoid reaching rate-limits.

Limiting the number of parallel jobs also makes CI faster overall, because other long jobs can start earlier.

Review

This is a routine fix.

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

Follow Up Work

We could stop installing protoc that way if the bug happens again.

@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-Medium ⚡ I-integration-fail Continuous integration fails, including build and test failures C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Oct 17, 2023
@teor2345 teor2345 requested a review from a team as a code owner October 17, 2023 00:19
@teor2345 teor2345 self-assigned this Oct 17, 2023
@teor2345 teor2345 requested review from oxarbitrage and removed request for a team October 17, 2023 00:19
@mpguerra mpguerra linked an issue Oct 17, 2023 that may be closed by this pull request
CI fails because the API rate limit is exceeded during protoc install #6702
Closed
Base automatically changed from refactor-workflows to main October 18, 2023 06:16
@mergify mergify bot requested a review from a team as a code owner October 18, 2023 06:16
@teor2345
Copy link
Contributor Author

I have manually confirmed that this change works: it is currently running and only 2 build crates jobs are active:
Screenshot 2023-10-19 at 08 29 53

oxarbitrage
oxarbitrage approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks.

mergify bot added a commit that referenced this pull request Oct 19, 2023
@mergify
Merge of #7754
a6914c2
@mergify mergify bot mentioned this pull request Oct 19, 2023
Closed
@mergify mergify bot merged commit 8c01fec into main Oct 19, 2023
71 checks passed
@mergify mergify bot deleted the limit-crate-ci branch October 19, 2023 13:41
@teor2345 teor2345 mentioned this pull request Nov 5, 2023
Merged
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI fails because the API rate limit is exceeded during protoc install
2 participants
@teor2345 @oxarbitrage