-
-
Notifications
You must be signed in to change notification settings - Fork 269
Is it possible to add support for MATLAB #28
Comments
Sorry for the late reply, I totally missed the notification. If Scintilla supports it and someone provides the keywords I could add it I guess. Although I don't use MATLAB at all so I need some good code samples to check if everything works. |
You can't attach anything on GitHub. So use the webform and upload the files somewhere easily accessible. |
You may get a copy from http://www.mathworks.com/matlabcentral/fileexchange/8550 . Thanks! |
Please try this build and let me know. Keep in mind that I don't use Matlab myself so there might be things that should be different. The code changes are in the Matlab branch here. Also the lexer itself which comes from Scintilla seem a little limited, for example it doesn't highlight block comments properly when I use |
I cannot do that because |
I didn't mean supported in Scintilla, since I know it's not... I mean that in general Anyway, not sure what I'm going to do with this patch since like I said above |
The matlab branch is up to date, but I still don't know if I should merge this. If anyone is interested to work on this, they are more than welcome to do so. |
Block comments are properly detected now with the updated Scintilla. |
Great news, very much appreciated! Any plan to merge this into the master branch? |
I cannot solve the issue with |
Another thing I noticed. M = regexp(str, {'(?-i)\w{5}(?=CASE)', ...
'(?i)\w{5}(?=CASE)'}, 'match');
M{:}
ans =
'UPPER'
ans =
'UPPER' 'lower'
break If I comment out M = regexp(str, {'(?-i)\w{5}(?=CASE)', ...
'(?i)\w{5}(?=CASE)'}, 'match');
M{:}
%{ans =
'UPPER'%}
ans =
'UPPER' 'lower'
break It shows as if it's commented out until the end. But this is a Scintilla issue. |
MATLAB editor handles it this way too. It works if you put %} into a separate line as below. M{:} |
So does this mean that the code isn't commented out unless |
M{:} I meant at least that the MATLAB editor shows the above code as if it's commented out until the end. |
Yes I got that, but does it work as expected? If yes then their editor has the same issue or the specs must say that the it must be in a new line. |
Yes, I believe the document says the opening and closing of the comment blocks have to be in their own lines. |
That's too bad cause I can't fix it properly at this point. I'll add this in the PR's todo. |
Thanks very much for your extra efforts! Any chance you could put a x64 build somewhere? I only have VS2010 Express and can not compile np2-mod with it any more. |
I added the VS2010 scripts and stuff back. |
I want a x86 Notepad2 copy supported MATLAB too. |
No, sorry. You can see #36 and help me fix the TODO issues; then it will be merged in the master branch. |
Your previous link is dead. Basically I rebased the I had to fix a minor bug in The stream comment bug discussed is obviously still there (someone ought to fix the MATLAB lexer in upstream Scintilla). I think it's a minor thing and I can live with it for the moment... Better than having no MATLAB support at all :) If anyone is interested in working on fixing the bug, here are the doc pages for the "block comment" construct: |
@amroamroamro: please don't distribute random builds. If you want to help, you can help by fixing the TODOs from #36. |
@XhmikosR: Fair enough. Do you want me to remove the link? I was just trying to give a quick solution for those who dont have the necessary dev tools installed... |
That is not a quick solution. The patch isn't ready; if it was, it would have been merged. So, yeah, please remove any links. |
can someone try the build from https://github.com/zufuliu/notepad2/releases? |
@zufuliu: you could rebase my branch and make any changes there and submit a PR where you CC me. |
MATLAB is gaining its popularity among engineering professionals and students; Its creator, MathWorks, claims that it has over 2 million users worldwide. Is it possible for you to add support for MATLAB please? Thanks very much!
The text was updated successfully, but these errors were encountered: