Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow an exclude list for users often mentioned incorrectly. #138

Open
peterwilsoncc opened this issue Aug 1, 2024 · 3 comments
Open

Allow an exclude list for users often mentioned incorrectly. #138

peterwilsoncc opened this issue Aug 1, 2024 · 3 comments
Assignees
Labels
[Type] Feature Request New feature or request

Comments

@peterwilsoncc
Copy link
Contributor

Problem

This comes out of the comment from the GitHub user paul who is frequently mentioned due to some incorrect meta data

Could you fix your bot that keeps mentioning me? I'm getting dozens of notifications a month from this project. https://github.com/WordPress/wordpress-develop/pulls?q=sort%3Aupdated-desc+%22%40paul%22

WordPress/wordpress-develop#6465 (comment)

Feature Request

Add a configurable attribute to be added on either a repo or organisation wide option to block particular users from being mentioned by the bot.

It would be good if there could be a way of doing this so it applies to both trunk and backport branches of the various projects.

Workaround

We could add the user paul to the manual exclude list but having it configurable would be preferable.

Repository

https://github.com/WordPress/wordpress-develop

@peterwilsoncc peterwilsoncc added the [Type] Feature Request New feature or request label Aug 1, 2024
@desrosj
Copy link
Contributor

desrosj commented Oct 8, 2024

Hmm, it seems that this scenario was caused by paul bearne incorrectly being interpreted as paul, which seems like a bug.

I don't love the idea of having to maintain an exclude list. Users should only be pinged if their .org/GH accounts are not linked. Maybe instead there is a way that the bot would only ping unlinked accounts once in a while to avoid being pinged repeatedly?

@swissspidy
Copy link
Member

Maybe a hardcoded exclude list just for paul while figuring out the bug that causes the mis-ping? Throttling pings seems like an overkill and would not address this bug either.

@peterwilsoncc
Copy link
Contributor Author

The misidentification by the bot was caused by the commiter meta data not being a valid email address, paul bearne <paul>, maybe some simple validation would help to ensure the email address contains an @ and a . character. Anything else can be assumed to be a failure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Feature Request New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants