Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to localise background image in Cover block with fixed or repeat background #748

Open
iamtakashi opened this issue Nov 27, 2024 · 1 comment · May be fixed by #750
Open

Fails to localise background image in Cover block with fixed or repeat background #748

iamtakashi opened this issue Nov 27, 2024 · 1 comment · May be fixed by #750
Assignees
@matiasbenedetto
Labels
bug Something isn't working

Comments

@iamtakashi
Copy link

When one of the settings or both is enabled, CBT fails to localise the image path in a Cover block even if the localised image option is on.

For example,

http://localhost.local/wp-content/uploads/2024/09/image.jpg should become <?php echo esc_url( get_template_directory_uri() ); ?>/assets/images/image.jpg, but it stays the absolute path in this case.

Image

Image

Image
@iamtakashi iamtakashi mentioned this issue Nov 27, 2024
Merged
@matiasbenedetto matiasbenedetto self-assigned this Nov 27, 2024
@matiasbenedetto matiasbenedetto linked a pull request Nov 27, 2024 that will close this issue
Open
@matiasbenedetto
Copy link
Contributor

A potential fix for this: #750

@matiasbenedetto matiasbenedetto added the bug Something isn't working label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matiasbenedetto matiasbenedetto

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use url attr to get the url of the media used by cover block WordPress/create-block-theme
2 participants
@iamtakashi @matiasbenedetto