Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big / Small attribute Feature Request #597

Open
2 tasks done
Ozphilo opened this issue Oct 6, 2024 · 9 comments
Open
2 tasks done

Big / Small attribute Feature Request #597

Ozphilo opened this issue Oct 6, 2024 · 9 comments
Labels
NF-0: Accepted Accepted Status NF-0: Pending Investigation New Features: Pending Investigation NF-2: Implementation - In Progress Implementation: In Progress P0: New Feature Request For New Features Requested

Comments

@Ozphilo
Copy link

Ozphilo commented Oct 6, 2024

Is your feature request related to a problem?

Not related to a problem at all, just in light of recent updates and community members request we felt this was the best solution for a community request since it would be adjustable on a per player basis rather then on a mod or admin level request. Also if as a mod we set the attribute level on an armor stand its lost upon breaking and replacing due to the uuid tag changing, or at least that is my assumption anyway.

Describe the solution you'd like.

/attribute (Armorstand) minecraft:generic.scale base set from .05 to 16 min/max adjustable through the config file allowing players to scale the attribute with the click of a mouse while holding flint similarly like we do with the xyz value adjustments.

Requesting feature enabled disabled adjustable through the config file

Perm nodes in place for the ability to true false the attribute request on armor stands through things like luck perms.

Anything you think would benefit the community from additional features to this feature request.

We think this would be a huge hit with in armor stand communities and greatly appreciate the consideration in adding this feature to the ASE Plugin :)

Describe alternatives you've considered.

We have considering resetting attributes each time but for larger communities it could eat up a lot of time on the mod/admin team.

Not allowing the request at all and telling the community we won't be able to honor the request.

Agreements

  • I have searched for and ensured there isn't already an open issue regarding this.
  • I have ensured the feature I'm requesting isn't already in the latest supported Paper build.

Other

image
image

@DreiFxn
Copy link

DreiFxn commented Nov 22, 2024

This feature would be nice

  • Drei

@Wolfieheart Wolfieheart added the NF-0: Pending Investigation New Features: Pending Investigation label Dec 3, 2024
@Wolfieheart
Copy link
Owner

@DreiFxn ping me with this one later today as a reminder. WIll try to set sometime to deal with this one :)

@DreiFxn
Copy link

DreiFxn commented Dec 3, 2024

@Wolfieheart BUMP,k bit late xD

@Bacore
Copy link

Bacore commented Dec 8, 2024

I too would like this feature. I will add that there are other armor stand editors which do have this feature. However I am of course wanting it for this plugin as I think it has the best GUI.

@Wolfieheart Wolfieheart added P0: New Feature Request For New Features Requested NF-0: Accepted Accepted Status NF-2: Implementation - In Progress Implementation: In Progress labels Dec 8, 2024
@Wolfieheart
Copy link
Owner

Wolfieheart commented Dec 9, 2024

Note on this one:

  • Basically in the code for Minecraft Attribute.GENERIC_SCALE only exists in 1.21.1
  • Once you upgrade to 1.21.3 or HIGHER, that value changes to Attribute.Scale and therefore causes scaling to break

So what do yall want -
I fix it in 1.21.1 and then say 6 weeks from now refix it for 1.21.3 or higher
Or do I act and just do it as if users are running 1.21.3 or higher?

@Ozphilo
Copy link
Author

Ozphilo commented Dec 9, 2024

Note on this one:

  • Basically in the code for Minecraft Attribute.GENERIC_SCALE only exists in 1.21.1
  • Once you upgrade to 1.21.3 or HIGHER, that value changes to Attribute.Scale and therefore causes scaling to break

So what do yall want - I fix it in 1.21.1 and then say 6 weeks from now refix it for 1.21.3 or higher Or do I act and just do it as if users are running 1.21.3 or higher?

Personally I'd like a 1.21.1 version first. Still running a few servers on that version and know people would be excited for the feature.

@DreiFxn
Copy link

DreiFxn commented Dec 9, 2024

I´m also prefering 1.21.1 for now, as a fullrelease with this feature, since 1.21.4 paper is not stable yet.

  • Drei

@Wolfieheart
Copy link
Owner

Wolfieheart commented Dec 9, 2024

Also I will make it somewhat BC (so that for people running NON 1.21.1, it does the old behaviour.

Making the attribute BC wont work directly since its not in the code and refuses to compile.

@Wolfieheart
Copy link
Owner

Now that 1.21.4 is considered available for Paper, Ill keep the code as is and not commit the 1.21.1 varient since it does the same thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NF-0: Accepted Accepted Status NF-0: Pending Investigation New Features: Pending Investigation NF-2: Implementation - In Progress Implementation: In Progress P0: New Feature Request For New Features Requested
Projects
None yet
Development

No branches or pull requests

4 participants