Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privacy Manifests #1420

Open
wlxo0401 opened this issue Dec 12, 2023 · 12 comments
Open

Privacy Manifests #1420

wlxo0401 opened this issue Dec 12, 2023 · 12 comments

Comments

@wlxo0401
Copy link
Contributor

wlxo0401 commented Dec 12, 2023

I don't have a bug

I think we need Privacy Manifests due to Apple policy.

Read Apple docs, which say:


From Fall 2023 you’ll receive an email from Apple if you upload an app to App Store Connect that uses required reason API without describing the reason in its privacy manifest file. From Spring 2024, apps that don’t describe their use of required reason API in their privacy manifest file won’t be accepted by App Store Connect.

@wlxo0401 wlxo0401 changed the title Is FSCalendar not related to privacy manifest? Is FSCalendar not related to Privacy Manifests? Dec 12, 2023
@wlxo0401 wlxo0401 changed the title Is FSCalendar not related to Privacy Manifests? Privacy Manifests Dec 12, 2023
@wlxo0401
Copy link
Contributor Author

@WenchaoD

Hello, my friend WenchaoD

I am using your FSCalendar well.

Thank you for checking even during your busy time.

My focus is that I think we need PrivacyManifest in FSCalendar.

The document below introduces what PrivacyManifest should contain.
https://developer.apple.com/documentation/bundleresources/privacy_manifest_files

Apple has asked third-party library developers to apply it.

This will also affect the submission of the app to the App Store.

I think this policy, which will take effect in spring 2024, is very important.

I think FSCalendar should include something that corresponds to or does not correspond to privacy policy.

Below are other related documents. (There may be more.)
https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api
https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_data_use_in_privacy_manifests
https://developer.apple.com/app-store/user-privacy-and-data-use/

Now, other libraries are applying this, but I don't think Apple has responded to the libraries that have been applied.

So even if you support PrivacyManifest, you'll have to wait and see how Apple responds for a while. If it's wrong, you might need to fix PrivacyManifest.

I saw that you said you were slow to respond. So, on the other hand, I'm worried about responding to Apple policy.

If you know anything about this or if I'm wrong, please let me know.

I am really grateful that you made FSCalendar. I hope to continue to use it consistently in the future.

I used a translator.

Please feel free to leave your opinions.

@wlxo0401
Copy link
Contributor Author

wlxo0401 commented Jan 26, 2024

I discovered a new while testing.

Until now, most of the libraries that have added PrivacyInfo have not been marked in PrivacyReport.

However, when an item is added to the 'Privacy Nutrition Label Types', the library name is displayed in the PrivacyReport.

Many libraries have updated PrivacyInfo without adding anything from 'Privacy Nutrition Label Types'.

Does anyone know about this? Is 'Privacy Nutrition Label Types' a must-have item?

Or is it not necessary to display it in the privacy report?

Please feel free to leave opinion.

The 'PrivacyReport' I'm talking about can be downloaded as a PDF if you archive the app.

https://developer.apple.com/videos/play/wwdc2023/10060/
Please refer to 3:20.

  1. Open your project in Xcode.

  2. Choose Product > Archive. Xcode creates the archive and reveals it in the organizer.

  3. Control-click the archive in the organizer and choose Generate Privacy Report.

(I used a translator.)

@wlxo0401
Copy link
Contributor Author

No one's interested in this?

@dpakthakur
Copy link

Yes. Any update on the Privacy Manifest Report for this pod?

@wlxo0401
Copy link
Contributor Author

wlxo0401 commented Mar 4, 2024

Yes. Any update on the Privacy Manifest Report for this pod?

@dpakthakur Thank you for your response

I tried sending an e-mail to @WenchaoD, but I didn't get a response.

Can we solve this if we use the Fork repository you created??

https://github.com/dpakthakur/FSCalendar/commits/master/

Or will @WenchaoD have to merge to solve the problem..

Why don't you PR your commit??

@dpakthakur
Copy link

@wlxo0401 the values in the xcprivacy file are not correct. I can for few more days to get a reply from @WenchaoD.. If not, I will create my own archive from the sample project of this pod, export and commit in my fork. I did not create a PR as I wanted to experiment on the privacy file.

@wlxo0401
Copy link
Contributor Author

wlxo0401 commented Mar 4, 2024

@wlxo0401 the values in the xcprivacy file are not correct. I can for few more days to get a reply from @WenchaoD.. If not, I will create my own archive from the sample project of this pod, export and commit in my fork. I did not create a PR as I wanted to experiment on the privacy file.

@dpakthakur

ssscccrrreeenn

How did you get in touch? I used an email.

The first time I sent it was January 2, 2024.

@WenchaoD replied on January 4, 2024. But he never responded after that.

@WenchaoD seems to be having a busy time.

And I hope we need more additional managers..

This is for the reason that if this is applied incorrectly, immediate correction is also needed.

@dpakthakur
Copy link

dpakthakur commented Mar 4, 2024

@WenchaoD @wlxo0401 I added the privacy info file here. I cannot make a PR for this repo because I do not have access to push my changes to a separate branch. I created the privacy manifest file here https://github.com/dpakthakur/FSCalendar/blob/master/Example-Objc/PrivacyInfo.xcprivacy. Please review and let me know in case of any corrections needed.

@wlxo0401
Copy link
Contributor Author

wlxo0401 commented Mar 7, 2024

@dpakthakur

If there is no update by March 13, I think we should test the App Store review by applying the repository you created.

We have time until May and I think we can solve it if we revise your repository together.

@wlxo0401
Copy link
Contributor Author

wlxo0401 commented Mar 9, 2024

@dpakthakur What did you see and add 'Privacy Tracking Domains', 'Privacy Nutrition Label Types', 'Privacy Tracking Enabled'??

@dpakthakur
Copy link

@wlxo0401 I corrected the manifest file and its path in podspec. Please check.

@wlxo0401
Copy link
Contributor Author

@dpakthakur

I have researched the Privacy Manifest and tested it through Apple's review process.

Furthermore, I have seen recommendations on the Apple Developer Forum against adding an empty Privacy Manifest unless necessary.

It wasn't a problem that I didn't have FSCalendar's PrivacyInfo in the process of testing.

And in the case of the .a library that is being used internally, we have confirmed that adding Privacy Type to the app's PrivacyInfo will eliminate the problem.

I guess it's not checking each library, but checking the entire app at once.

Keep in mind that we are currently in a phase where warnings are issued via email, and Apple's approach may change when these policies are officially implemented in May.

Please feel free to share your opinions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants