Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up for Component base class #92

Open
blinkdog opened this issue Feb 6, 2020 · 0 comments
Open

Clean up for Component base class #92

blinkdog opened this issue Feb 6, 2020 · 0 comments

Comments

@blinkdog
Copy link
Contributor

blinkdog commented Feb 6, 2020

The status_loop and work_loop of components calls check_drain_semaphore.

This seemed like a good idea before, but the way we run components makes this obsolete.
Generally:

  • We are running a component as a long-running daemon inside Kubernetes; the system can/will kill it at any time without providing a semaphore
  • We are running a component as a free-standing daemon on some host (i.e.: Bundlers on node007, c8-7, and c9-7); these are also killed without providing any semaphore
  • We are running the components as RUN_ONCE_AND_DIE as part of jobs at NERSC; these die after processing one unit of work and would not use the semaphore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant