Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Update dependencies #1281

Closed
3 tasks
gislawill opened this issue Jun 20, 2024 · 2 comments
Closed
3 tasks

[Feature Request]: Update dependencies #1281

gislawill opened this issue Jun 20, 2024 · 2 comments
Assignees
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request Epic Epics contain issues related to a subject, and the scope is flexible triage to be triaged for next action

Comments

@gislawill
Copy link
Collaborator

Provide a clear and concise description of what you want to happen.

The PRISM codebase has several important outdated dependencies. There are a few issues this creates:

  • It's more difficult to incorporate new packages (for example, we can't use the latest version of react-markdown)
  • We risk losing support in our CI/CD runners for the deprecated version of node we depend on
  • Our development environment is slower than it should be and doesn't have support for the latest tooling (for example, hot module reloading)

We will eventually be forced to update our dependencies for one reason or another. Best to do it on our own terms so we're investing this effort at the right time in our product roadmap to ensure it's not conflicting with feature timelines.

Most important updates to make:

  • Node v16 to Node v20
    Node v16 is no longer actively maintained by the Node team (source). We should upgrade to LTS (currently v20) to ensure we're able to use the new libraries and all CI/CD environments
  • React v16 to React v18
    React v18 provides a few new APIs for data fetching and loading experiences as well as performance improvements in both production and development. Once again, many open-source libraries now have a peer-dependency on v18 so we need to upgrade to continue to use the latest
  • React Scripts v3 - React Scripts v5 (aka Create React App)
    This update will improve our development experience (faster development environment with hot module reloading). Alternatively we could switch to Vite — my only preference is for whichever we think will require less effort to be functional.

Is there anything else you can add about the proposal? You might want to link to related issues here, if you haven't already.

We currently have a draft PR from a few months ago migrating Create React App to Vite (#1210). It looks like this tried to take on all of the updates in one go — we may have more luck if we break the updates into smaller pieces,

@gislawill gislawill added enhancement New feature or request dependencies Pull requests that update a dependency file Epic Epics contain issues related to a subject, and the scope is flexible triage to be triaged for next action labels Jun 20, 2024
@gislawill
Copy link
Collaborator Author

@ericboucher flagging for your thoughts — particularly around timing and how important/urgent you think these dependency updates are.

@gislawill
Copy link
Collaborator Author

Closing now that #1210 is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request Epic Epics contain issues related to a subject, and the scope is flexible triage to be triaged for next action
Projects
None yet
Development

No branches or pull requests

2 participants