From 31132b51889acb9a40df77f05c462352e9f93ca1 Mon Sep 17 00:00:00 2001 From: Wojciech Mazur Date: Thu, 1 Feb 2024 18:52:29 +0100 Subject: [PATCH 1/8] Allow to add extra library deps to sbt projects --- project-builder/sbt/CommunityBuildPlugin.scala | 17 ++++++++++++----- .../shared/CommunityBuildCore.scala | 18 +++++++++++++++++- 2 files changed, 29 insertions(+), 6 deletions(-) diff --git a/project-builder/sbt/CommunityBuildPlugin.scala b/project-builder/sbt/CommunityBuildPlugin.scala index d991b183..5703a76e 100644 --- a/project-builder/sbt/CommunityBuildPlugin.scala +++ b/project-builder/sbt/CommunityBuildPlugin.scala @@ -85,11 +85,18 @@ object CommunityBuildPlugin extends AutoPlugin { } .getOrElse(Nil) - override def projectSettings = - Seq( - // Fix for cyclic dependency when trying to use crossScalaVersion ~= ??? - crossScalaVersions := (thisProjectRef / crossScalaVersions).value - ) ++ mvnRepoPublishSettings + override def projectSettings = Seq( + // Fix for cyclic dependency when trying to use crossScalaVersion ~= ??? + crossScalaVersions := (thisProjectRef / crossScalaVersions).value, + libraryDependencies ++= extraLibraryDependencies((thisProjectRef / scalaVersion).value) + ) ++ mvnRepoPublishSettings + + private def extraLibraryDependencies(scalaVersion: String) = + if (!scalaVersion.startsWith("3.")) Nil + else + Utils.extraLibraryDependencies.map { case Utils.LibraryDependency(org, artifact, version) => + org % artifact % version + } private def stripScala3Suffix(s: String) = s match { case WithExtractedScala3Suffix(prefix, _) => prefix; case _ => s diff --git a/project-builder/shared/CommunityBuildCore.scala b/project-builder/shared/CommunityBuildCore.scala index 3d10a0a2..651f0601 100644 --- a/project-builder/shared/CommunityBuildCore.scala +++ b/project-builder/shared/CommunityBuildCore.scala @@ -414,6 +414,22 @@ object Scala3CommunityBuild { definedSourceVersion.isEmpty && isMatching("is dangling source version",SourceVersionPattern.findFirstIn(s.trim())) } ++ appendSettings.distinct } - + + case class LibraryDependency(organization: String, artifact: String, version: String) + lazy val extraLibraryDependencies: Seq[LibraryDependency] = sys.props + .getOrElse("communitybuild.project.dependencies.add", "") + .split(';') + .filter(_.nonEmpty) + .map(dep => dep.trim().split(':')) + .flatMap { + case Array(org, artifact, version) => + val dep = LibraryDependency(org, artifact, version) + logOnce(s"Would include extra dependency: org=$org, artifact=$artifact, version=$version") + Some(dep) + case segments => + logOnce(s"Invalid dependency format, segments=${segments.toList}") + None + } } + } From 3ef6760133e583d38dc3a3e20dc79dd1c8d944fe Mon Sep 17 00:00:00 2001 From: Wojciech Mazur Date: Thu, 1 Feb 2024 18:52:49 +0100 Subject: [PATCH 2/8] Fix projects config for disneystreaming/smithy-translate --- coordinator/configs/projects-config.conf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/coordinator/configs/projects-config.conf b/coordinator/configs/projects-config.conf index 6a864882..29678ef2 100644 --- a/coordinator/configs/projects-config.conf +++ b/coordinator/configs/projects-config.conf @@ -207,7 +207,7 @@ disneystreaming_smithy4s { disneystreaming_smithy-translate { source-patches = [{ path = "buildSetup.sc" - pattern = "case ZincWorkerUtil.DottyVersion("0"," + pattern = "case ZincWorkerUtil.DottyVersion(\"0\"," replace-with = "case ZincWorkerUtil.Scala3Version(" }] } From 2ac2fee6cbae60e9920fbbdd2140d01bc6ce76e3 Mon Sep 17 00:00:00 2001 From: Wojciech Mazur Date: Thu, 1 Feb 2024 20:37:06 +0100 Subject: [PATCH 3/8] Allow to pass custom deps to scala-cli projects, fix typos --- project-builder/scala-cli/build.scala | 25 ++++++++++++++++++------- 1 file changed, 18 insertions(+), 7 deletions(-) diff --git a/project-builder/scala-cli/build.scala b/project-builder/scala-cli/build.scala index 400c25a1..e658be06 100644 --- a/project-builder/scala-cli/build.scala +++ b/project-builder/scala-cli/build.scala @@ -13,8 +13,13 @@ import os.CommandResult repositoryDir: String, scalaVersion: String, configJson: String, - mavenRepoURL: String + mavenRepoURL: String, + extraLibraryDependenciesString: String ): Unit = { + // For compatibility with other build tools s use logic from CBCore + // Set system property if missing + sys.props.getOrElseUpdate(Utils.ExtraLibraryDependenciesProp, extraLibraryDependenciesString) + println(System.getProperty(Utils.ExtraLibraryDependenciesProp)) println(s"Build config: ${configJson}") val config = if (configJson.isEmpty()) ProjectBuildConfig() @@ -102,7 +107,9 @@ import os.CommandResult case class CliCommand[T]( command: Seq[String], errHandler: (CommandResult, EvalResult.Failure) => EvalResult[T] -) +){ + override def toString(): String = s"${command.mkString(" ")}" +} def cmd(args: String*) = CliCommand[Unit](args, (_, failure) => failure) class CliTaskEvaluator(scalaVersion: String, repositoryDir: String, mavenRepoURL: Option[String]) extends TaskEvaluator[CliCommand] { @@ -120,6 +127,9 @@ class CliTaskEvaluator(scalaVersion: String, repositoryDir: String, mavenRepoURL } def eval[T](task: CliCommand[T]): EvalResult[T] = { + val extraLibraryDependencies = Utils.extraLibraryDependencies.map{ + case Utils.LibraryDependency(org, artifact, version) => s"--dependency=$org:$artifact:$version" + } val evalStart = System.currentTimeMillis() val proc = os .proc( @@ -130,9 +140,10 @@ class CliTaskEvaluator(scalaVersion: String, repositoryDir: String, mavenRepoURL s"--server=false", s"--scala-version=${scalaVersion}", "--scalac-option=-J-Xss10M", - "--scalac-option=-J-Xmx=7G", - "--scalac-option=-J-Xms=4G", - mavenRepoURL.map(s"--repository=" + _).getOrElse("") + "--scalac-option=-J-Xmx7G", + "--scalac-option=-J-Xms4G", + mavenRepoURL.map(s"--repository=" + _).toList, + extraLibraryDependencies ) .call(check = false, stderr = os.Pipe) val result = proc.exitCode @@ -140,10 +151,10 @@ class CliTaskEvaluator(scalaVersion: String, repositoryDir: String, mavenRepoURL def nullT = null.asInstanceOf[T] result match { case 0 => - println(s"Successfully evaluated $task") + println(s"Successfully evaluated: $task") EvalResult.Value(nullT, evalTime = tookMillis) case exitCode => - println(s"Failed to evaluated $task: exitCode ${exitCode}") + println(s"Failed to evaluated: $task, exitCode ${exitCode}") proc.err.lines().foreach(System.err.println) val failure = EvalResult.Failure( EvaluationFailure(proc.err.toString()) :: Nil, From 1607d8cc292b4a1d6898ed9c996fd983e32c1b0c Mon Sep 17 00:00:00 2001 From: Wojciech Mazur Date: Thu, 1 Feb 2024 20:40:14 +0100 Subject: [PATCH 4/8] Actually pass injected library deps via build-revision.sh --- .github/actions/build-project/action.yaml | 4 +++- cli/scb-cli.scala | 3 ++- k8s/project-builder-mill-test.yaml | 1 + k8s/project-builder-sbt-test.yaml | 1 + project-builder/build-revision.sh | 15 +++++++++++---- project-builder/mill/MillCommunityBuild.sc | 2 +- project-builder/sbt/build.sh | 4 +++- project-builder/shared/CommunityBuildCore.scala | 3 ++- scripts/bisect.scala | 4 +++- scripts/run.sh | 5 ++++- 10 files changed, 31 insertions(+), 11 deletions(-) diff --git a/.github/actions/build-project/action.yaml b/.github/actions/build-project/action.yaml index 4bbf1c76..700d9fff 100644 --- a/.github/actions/build-project/action.yaml +++ b/.github/actions/build-project/action.yaml @@ -139,7 +139,9 @@ runs: '1.6.2' \ "$(config .config // ${DefaultConfig})" \ "${{ inputs.extra-scalac-options }}" \ - "${{ inputs.disabled-scalac-options }}" 2>&1 | tee build-logs.txt + "${{ inputs.disabled-scalac-options }}" \ + "${{ inputs.extra-library-dependencies }}" \ + 2>&1 | tee build-logs.txt # Store results mv build-logs.txt /opencb/ diff --git a/cli/scb-cli.scala b/cli/scb-cli.scala index 46a770e8..100f0d34 100755 --- a/cli/scb-cli.scala +++ b/cli/scb-cli.scala @@ -767,7 +767,8 @@ object MinikubeReproducer: params.enforcedSbtVersion.getOrElse("1.6.2"), params.config.getOrElse("{}"), /* extra-scalac-options = */ "", - /* disabled-scalac-options = */ "" + /* disabled-scalac-options = */ "", + /* extra-library-deps = */ "" ) ) ), diff --git a/k8s/project-builder-mill-test.yaml b/k8s/project-builder-mill-test.yaml index 8c75ad1d..d391b1f3 100644 --- a/k8s/project-builder-mill-test.yaml +++ b/k8s/project-builder-mill-test.yaml @@ -25,6 +25,7 @@ spec: '{"projects": {"exclude": ["dummy.org%dummy-.*"], "overrides": {"upickle-core": {"tests": "compile-only"}, "ujson": {"tests": "disabled"}} } }' \ "" \ "" \ + "" \ && echo \ && echo "Community project published successfully") || true restartPolicy: Never diff --git a/k8s/project-builder-sbt-test.yaml b/k8s/project-builder-sbt-test.yaml index dfe6ecf5..8848e598 100644 --- a/k8s/project-builder-sbt-test.yaml +++ b/k8s/project-builder-sbt-test.yaml @@ -28,6 +28,7 @@ spec: '{"sbt": {"commands": ["show crossScalaVersions", "show scalaVersion", "show scalacOptions"] }, "projects": {"exclude": ["dummy.org%dummy-.*"], "overrides": {"shapeless3-deriving": {"tests": "compile-only"}, "shapeless3-typeable": {"tests": "disabled"}} } }' \ "" \ "" \ + "" \ && echo \ && echo "Community project published successfully") || true restartPolicy: Never diff --git a/project-builder/build-revision.sh b/project-builder/build-revision.sh index 89dcd547..b987c31f 100755 --- a/project-builder/build-revision.sh +++ b/project-builder/build-revision.sh @@ -1,8 +1,8 @@ #!/usr/bin/env bash set -e -if [ $# -ne 11 ]; then - echo "Wrong number of script arguments, got $# expected 11" +if [ $# -ne 12 ]; then + echo "Wrong number of script arguments, got $# expected 12" exit 1 fi @@ -17,6 +17,7 @@ enforcedSbtVersion="$8" # e.g. '1.5.5' or empty '' projectConfig="$9" extraScalacOptions="${10}" # e.g '' or "-Wunused:all -Ylightweight-lazy-vals" disabledScalacOption="${11}" +extraLibraryDeps="${12}" # format org:artifact:version, eg. org.scala-lang:scala2-library-tasty_3:3.4.0-RC1 scriptDir="$(cd "$(dirname "${BASH_SOURCE[0]}")" &>/dev/null && pwd)" export OPENCB_SCRIPT_DIR=$scriptDir @@ -54,6 +55,12 @@ if [ -z $disabledScalacOption ];then disabledScalacOption="$commonRemoveScalacOp else disabledScalacOption="$disabledScalacOption,$commonRemoveScalacOptions"; fi +if [[ ! -z $extraLibraryDeps ]]; then + echo "Would try to append extra library dependencies (best-effort, sbt/scala-cli only): ${extraLibraryDeps}" +fi + +echo "" +echo "----" if [ -f "repo/mill" ] || [ -f "repo/build.sc" ]; then echo "Mill project found: ${isMillProject}" echo "mill" > $buildToolFile @@ -64,12 +71,12 @@ elif [ -f "repo/build.sbt" ]; then echo "sbt project found: ${isSbtProject}" echo "sbt" > $buildToolFile $scriptDir/sbt/prepare-project.sh "$project" repo "$enforcedSbtVersion" "$scalaVersion" "$projectConfig" - $scriptDir/sbt/build.sh repo "$scalaVersion" "$version" "$targets" "$mvnRepoUrl" "$projectConfig" "$extraScalacOptions" "$disabledScalacOption" + $scriptDir/sbt/build.sh repo "$scalaVersion" "$version" "$targets" "$mvnRepoUrl" "$projectConfig" "$extraScalacOptions" "$disabledScalacOption" "$extraLibraryDeps" else echo "Not found sbt or mill build files, assuming scala-cli project" ls -l repo/ echo "scala-cli" > $buildToolFile scala-cli clean $scriptDir/scala-cli/ scala-cli clean repo - scala-cli $scriptDir/scala-cli/build.scala -- repo "$scalaVersion" "$projectConfig" "$mvnRepoUrl" + scala-cli $scriptDir/scala-cli/build.scala -- repo "$scalaVersion" "$projectConfig" "$mvnRepoUrl" "$extraLibraryDeps" fi diff --git a/project-builder/mill/MillCommunityBuild.sc b/project-builder/mill/MillCommunityBuild.sc index bb6b62b5..d9eb3ba1 100644 --- a/project-builder/mill/MillCommunityBuild.sc +++ b/project-builder/mill/MillCommunityBuild.sc @@ -112,7 +112,7 @@ def mapCrossVersions[T]( version <- Seq(mappedCross, crossEntry).distinct } yield { if (version != crossEntry) { - println(s"Use cross-version $mappedCross instead of $crossEntry") + logOnce(s"Use cross-version $mappedCross instead of $crossEntry") } version.asInstanceOf[T] } diff --git a/project-builder/sbt/build.sh b/project-builder/sbt/build.sh index 95e1fba9..4225b42d 100755 --- a/project-builder/sbt/build.sh +++ b/project-builder/sbt/build.sh @@ -15,6 +15,7 @@ export CB_MVN_REPO_URL="$5" # e.g. https://mvn-repo/maven2/2021-05-23_1 projectConfig="$6" extraScalacOptions="$7" disabledScalacOption="$8" +extraLibraryDeps="$9" if [[ -z "$projectConfig" ]]; then projectConfig="{}" @@ -48,7 +49,8 @@ fi sbtSettings=( --batch --verbose - -Dcommunitybuild.version="$version" + "-Dcommunitybuild.version=$version" + "-Dcommunitybuild.project.dependencies.add=$extraLibraryDeps" ${memorySettings[@]} $(echo $projectConfig | jq -r '.sbt.options? // [] | join(" ")' | sed "s//${scalaVersion}/g") ) diff --git a/project-builder/shared/CommunityBuildCore.scala b/project-builder/shared/CommunityBuildCore.scala index 651f0601..7753d11a 100644 --- a/project-builder/shared/CommunityBuildCore.scala +++ b/project-builder/shared/CommunityBuildCore.scala @@ -416,8 +416,9 @@ object Scala3CommunityBuild { } case class LibraryDependency(organization: String, artifact: String, version: String) + final val ExtraLibraryDependenciesProp = "communitybuild.project.dependencies.add" lazy val extraLibraryDependencies: Seq[LibraryDependency] = sys.props - .getOrElse("communitybuild.project.dependencies.add", "") + .getOrElse(ExtraLibraryDependenciesProp, "") .split(';') .filter(_.nonEmpty) .map(dep => dep.trim().split(':')) diff --git a/scripts/bisect.scala b/scripts/bisect.scala index ffc262d9..6d3ad3fd 100755 --- a/scripts/bisect.scala +++ b/scripts/bisect.scala @@ -156,6 +156,7 @@ object ValidationScript: then "" else """* { "tests": "compile-only"} """ val revision = projectRevision.getOrElse("$(config .revision)") + val extraLibraryDependencies = "" raw""" |#!/usr/bin/env bash |set -e @@ -188,7 +189,8 @@ object ValidationScript: | '1.6.2' \ | "$$(config .config '$configPatch' // $${DefaultConfig} '$configPatch')" \ | "$extraScalacOptions" \ - | "$disabledScalacOption" + | "$disabledScalacOption" \ + | "$extraLibraryDependencies" | |grep -q "success" build-status.txt; |exit $$? diff --git a/scripts/run.sh b/scripts/run.sh index 3a5d1bf1..3d8bc71b 100755 --- a/scripts/run.sh +++ b/scripts/run.sh @@ -16,6 +16,7 @@ if [[ -z $scalaVersion ]]; then fi extraScalacOptions="" disabledScalacOptions="" +extraLibraryDependencies="org.scala-lang:scala2-library-tasty_3:3.4.1-RC1" echo "projectName: $projectName" echo "scalaVersion: $scalaVersion" @@ -39,6 +40,8 @@ $scriptDir/../project-builder/build-revision.sh \ '1.6.2' \ "$(config .config // ${DefaultConfig})" \ "$extraScalacOptions" \ - "$disabledScalacOptions" 2>&1 | tee build-logs.txt + "$disabledScalacOptions" \ + "$extraLibraryDependencies" \ + 2>&1 | tee build-logs.txt cat build-status.txt \ No newline at end of file From b302ed77b09d2d899e0ccae1162dd4b69caa7dbd Mon Sep 17 00:00:00 2001 From: Wojciech Mazur Date: Thu, 1 Feb 2024 20:41:44 +0100 Subject: [PATCH 5/8] Adjust workflows to pass extra dependencies --- .github/actions/build-project/action.yaml | 3 +++ .github/workflows/buildExecuteCustom-A.yaml | 9 +++++++-- .github/workflows/buildExecuteCustom-B.yaml | 9 +++++++-- coordinator/src/main/scala/buildPlan.scala | 5 +++++ 4 files changed, 22 insertions(+), 4 deletions(-) diff --git a/.github/actions/build-project/action.yaml b/.github/actions/build-project/action.yaml index 700d9fff..2d6326dd 100644 --- a/.github/actions/build-project/action.yaml +++ b/.github/actions/build-project/action.yaml @@ -13,6 +13,9 @@ inputs: disabled-scalac-options: description: "List of scalacOptions which should be filted out when building projects." default: "" + extra-library-dependencies: + description: "List of library dependencies which should be injected when building projects, in format org:artifact:version, cross versions are not supported. Multiple entires should be seperated by a single semicolon character `;`" + default: "" custom-build-id: description: "Custom buildId to use instead of autogenerated github job id" default: "" diff --git a/.github/workflows/buildExecuteCustom-A.yaml b/.github/workflows/buildExecuteCustom-A.yaml index a38256a6..d1eb3f83 100644 --- a/.github/workflows/buildExecuteCustom-A.yaml +++ b/.github/workflows/buildExecuteCustom-A.yaml @@ -21,11 +21,15 @@ on: default: "main" extra-scalac-options: type: string - description: "List of scalacOptions which should be used when building projects. Multiple entires should be seperated by a single comma character `,`" + description: "List of scalacOptions which should be used when building projects. Multiple entires should be seperated by a single comma character `,`. (Best effort)" default: "" disabled-scalac-options: type: string - description: "List of scalacOptions which should be filtered out when building projects." + description: "List of scalacOptions which should be filtered out when building projects. (Best effort)" + default: "" + extra-library-dependencies: + type: string + description: "List of library dependencies which should be injected when building projects, in format org:artifact:version, cross versions are not supported. Multiple entires should be seperated by a single semicolon character `;`. (Best effort)" default: "" push-to-gh-pages: type: boolean @@ -41,6 +45,7 @@ jobs: repository-branch: ${{ inputs.repository-branch }} extra-scalac-options: ${{ inputs.extra-scalac-options }} disabled-scalac-options: ${{ inputs.disabled-scalac-options }} + extra-library-dependencies: ${{ inputs.extra-library-dependencies }} custom-build-id: ${{ inputs.build-name }} secrets: inherit diff --git a/.github/workflows/buildExecuteCustom-B.yaml b/.github/workflows/buildExecuteCustom-B.yaml index f3338ca7..7e1307b0 100644 --- a/.github/workflows/buildExecuteCustom-B.yaml +++ b/.github/workflows/buildExecuteCustom-B.yaml @@ -21,11 +21,15 @@ on: default: "main" extra-scalac-options: type: string - description: "List of scalacOptions which should be used when building projects. Multiple entires should be seperated by a single comma character `,`" + description: "List of scalacOptions which should be used when building projects. Multiple entires should be seperated by a single comma character `,` (Best effort)" default: "" disabled-scalac-options: type: string - description: "List of scalacOptions which should be filtered out when building projects." + description: "List of scalacOptions which should be filtered out when building projects. (Best effort)" + default: "" + extra-library-dependencies: + type: string + description: "List of library dependencies which should be injected when building projects, in format org:artifact:version, cross versions are not supported. Multiple entires should be seperated by a single semicolon character `;`. (Best effort)" default: "" push-to-gh-pages: type: boolean @@ -41,6 +45,7 @@ jobs: repository-branch: ${{ inputs.repository-branch }} extra-scalac-options: ${{ inputs.extra-scalac-options }} disabled-scalac-options: ${{ inputs.disabled-scalac-options }} + extra-library-dependencies: ${{ inputs.extra-library-dependencies }} custom-build-id: ${{ inputs.build-name }} secrets: inherit diff --git a/coordinator/src/main/scala/buildPlan.scala b/coordinator/src/main/scala/buildPlan.scala index 4ec83d87..63c71790 100644 --- a/coordinator/src/main/scala/buildPlan.scala +++ b/coordinator/src/main/scala/buildPlan.scala @@ -532,6 +532,10 @@ def createGithubActionJob( | type: string | description: "List of scalacOptions which should be filtered out when building projects." | default: "" + | extra-library-dependencies: + | type: string + | description: "List of library dependencies which should be injected when building projects, in format org:artifact:version, cross versions are not supported. Multiple entires should be seperated by a single semicolon character `;`. (Best effort)" + | default: "" | custom-build-id: | type: string | description: "Custom buildId to use instead of autogenerated github job id" @@ -600,6 +604,7 @@ def createGithubActionJob( println(" custom-build-id: ${{ inputs.custom-build-id }}") println(" extra-scalac-options: ${{ inputs.extra-scalac-options }}") println(" disabled-scalac-options: ${{ inputs.disabled-scalac-options }}") + println(" extra-library-dependencies: ${{ inputs.extra-library-dependencies }}") println(s" scala-version: $${{ $setupOutputs.scala-version }}") println(s" maven-repo-url: $${{ $setupOutputs.maven-repo-url }}") println(" elastic-user: ${{ secrets.OPENCB_ELASTIC_USER }}") From c77a92c6ff1af0773359bc685ef39a963496d31d Mon Sep 17 00:00:00 2001 From: Wojciech Mazur Date: Thu, 1 Feb 2024 20:43:53 +0100 Subject: [PATCH 6/8] Set version to 0.3.4 --- .github/actions/build-project/action.yaml | 2 +- .github/actions/setup-build/action.yaml | 2 +- cli/scb-cli.scala | 2 +- scripts/bisect.scala | 2 +- scripts/build-all.sh | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/actions/build-project/action.yaml b/.github/actions/build-project/action.yaml index 2d6326dd..e675d487 100644 --- a/.github/actions/build-project/action.yaml +++ b/.github/actions/build-project/action.yaml @@ -110,7 +110,7 @@ runs: uses: addnab/docker-run-action@v3 if: steps.check-history.outputs.can-skip-build != 'true' with: - image: "virtuslab/scala-community-build-project-builder:jdk${{ env.java-version }}-v0.3.3" + image: "virtuslab/scala-community-build-project-builder:jdk${{ env.java-version }}-v0.3.4" options: -v ${{ github.workspace }}:/opencb/ -v ${{ github.workspace }}/github_key:/root/.ssh/github_key:ro run: | # Setup ssh required for downloading submodules diff --git a/.github/actions/setup-build/action.yaml b/.github/actions/setup-build/action.yaml index de3109b8..df978173 100644 --- a/.github/actions/setup-build/action.yaml +++ b/.github/actions/setup-build/action.yaml @@ -75,7 +75,7 @@ runs: uses: addnab/docker-run-action@v3 if: steps.check-published.outputs.is-compiler-published == 'false' with: - image: "virtuslab/scala-community-build-compiler-builder:v0.3.3" + image: "virtuslab/scala-community-build-compiler-builder:v0.3.4" options: -v ${{ github.workspace }}/compiler:/compiler/ run: | Version="${{ steps.calc-version.outputs.effective-scala-version }}" diff --git a/cli/scb-cli.scala b/cli/scb-cli.scala index 100f0d34..8dc833a1 100755 --- a/cli/scb-cli.scala +++ b/cli/scb-cli.scala @@ -31,7 +31,7 @@ class FailedProjectException(msg: String) with NoStackTrace val communityBuildVersion = - sys.props.getOrElse("communitybuild.version", "v0.3.3") + sys.props.getOrElse("communitybuild.version", "v0.3.4") private val CBRepoName = "VirtusLab/community-build3" val projectBuilderUrl = s"https://raw.githubusercontent.com/$CBRepoName/master/project-builder" diff --git a/scripts/bisect.scala b/scripts/bisect.scala index 6d3ad3fd..2dcd7aaa 100755 --- a/scripts/bisect.scala +++ b/scripts/bisect.scala @@ -9,7 +9,7 @@ import java.nio.file.attribute.PosixFilePermissions import java.nio.charset.StandardCharsets import java.nio.file._ -val communityBuildVersion = "v0.3.3" +val communityBuildVersion = "v0.3.4" @main def run(args: String*): Unit = val config = scopt.OParser diff --git a/scripts/build-all.sh b/scripts/build-all.sh index cd63663b..c5bc8a54 100755 --- a/scripts/build-all.sh +++ b/scripts/build-all.sh @@ -7,7 +7,7 @@ if [ $# -ne 1 ]; then fi VERSION="$1" -export PREV_CB_VERSION="v0.3.2" +export PREV_CB_VERSION="v0.3.3" javaDefault=11 javaAccessoryVersions=(8 17 21) From 337a25d19b2aa769ee2273cb0c0ede9bd9b5ebcb Mon Sep 17 00:00:00 2001 From: Wojciech Mazur Date: Thu, 1 Feb 2024 20:49:48 +0100 Subject: [PATCH 7/8] Remove extra deps in run.sh --- scripts/run.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/run.sh b/scripts/run.sh index 3d8bc71b..363473b5 100755 --- a/scripts/run.sh +++ b/scripts/run.sh @@ -16,7 +16,7 @@ if [[ -z $scalaVersion ]]; then fi extraScalacOptions="" disabledScalacOptions="" -extraLibraryDependencies="org.scala-lang:scala2-library-tasty_3:3.4.1-RC1" +extraLibraryDependencies="" echo "projectName: $projectName" echo "scalaVersion: $scalaVersion" From c6f86b66961548b58390b7d8eba217e86afe8b9e Mon Sep 17 00:00:00 2001 From: Wojciech Mazur Date: Thu, 1 Feb 2024 21:29:45 +0100 Subject: [PATCH 8/8] fix sbt/build.sh --- project-builder/sbt/build.sh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/project-builder/sbt/build.sh b/project-builder/sbt/build.sh index 4225b42d..88a2f935 100755 --- a/project-builder/sbt/build.sh +++ b/project-builder/sbt/build.sh @@ -2,8 +2,8 @@ set -e set -o pipefail -if [ $# -ne 8 ]; then - echo "Wrong number of script arguments, expected $0 , got $#: $@" +if [ $# -ne 9 ]; then + echo "Wrong number of script arguments, expected $0 , got $#: $@" exit 1 fi