Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Fix WebAuthn SHA256 returndatasize check #1224

Merged
merged 1 commit into from
Dec 16, 2024
Merged

♻️ Fix WebAuthn SHA256 returndatasize check #1224

merged 1 commit into from
Dec 16, 2024

Conversation

Vectorized
Copy link
Owner

@Vectorized Vectorized commented Dec 9, 2024 •
edited
Loading

Description

Helps sleep better at night.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

Gas Snapshot Comparison Report

Generated at commit : 8451bec, Compared to commit : 513f581

Contract Name Test Name Main Gas PR Gas Diff
WebAuthnTest testChrome() 192809 192815 6
testSafari() 192971 192977 6
test__codesize() 11680 11684 4

@Vectorized Vectorized merged commit 824ca8c into main Dec 16, 2024
11 checks passed
@Vectorized Vectorized deleted the webauthn-sha2-returndatasize branch December 16, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Vectorized