-
Notifications
You must be signed in to change notification settings - Fork 629
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
thread sanitizer detects issues #290
Comments
Thanks I will look into this. In general, yes you should be able to make API calls from multiple threads at the same time. (With the possible exception of "big" ones like init and kill.) Callbacks are "threadsafe", but they are queued, so there are just inherent race conditions you just have to be aware of. |
I don't really see how the unlock of an unlocked mutex one is possible, tbh. The code is pretty simple. I don't suppose you can share more info? Or perhaps send me a PR with a config to enable thread sanitizer that works on ubuntu? |
I have made a PR where sanitizer is used in the github actions. It shows there are issues, but it might be different from the issues previously found. I suppose this is as good starting point as any other. |
Thanks! Hopefully I will get a sec to try this out soon. |
I get warnings when running my tests with thread sanitizer. For example:
unlock of an unlocked mutex (click to expand)
data race (click to expand)
And many more...
I assume that all steam functions are thread-safe? I could not find spacific details on that in the documentation, other than a small note that callbacks are thread-safe.
I am compiling the code with clang++ version 14 with
-fsanitize=thread
running on ubuntu 22.Please let me know if you need any more information.
The text was updated successfully, but these errors were encountered: