diff --git a/public/locales/en/translation.json b/public/locales/en/translation.json index fb88f5c8f..4162c910a 100644 --- a/public/locales/en/translation.json +++ b/public/locales/en/translation.json @@ -309,7 +309,7 @@ "none": "none" }, "studentsWithFeedback": { - "cannotShowWhenOpen": "Information about students who have given feedback cannot be shown while the feedback is open.", + "cannotShowBeforeFeedbackEnds": "Information about students who have given feedback cannot be shown before the feedback period has ended.", "noFeedbackInfo": "Information about students who have given feedback cannot be shown. Either there are less than five students who have given feedback or the list of students who have given feedback is disabled in the programme's settings", "studentsList": "Students who have given feedback" }, diff --git a/public/locales/fi/translation.json b/public/locales/fi/translation.json index 5c4733b0f..d89fab9e9 100644 --- a/public/locales/fi/translation.json +++ b/public/locales/fi/translation.json @@ -308,7 +308,7 @@ "none": "ei ole" }, "studentsWithFeedback": { - "cannotShowWhenOpen": "Tietoa palautteen antajista ei voida näyttää palautteen ollessa auki.", + "cannotShowBeforeFeedbackEnds": "Tietoa palautteen antajista ei voida näyttää ennen kuin palautteenantojakso on päättynyt.", "noFeedbackInfo": "Tietoa palautteen antaneista opiskelijoista ei voida näyttää. Joko palautetta antaneita opiskelijoita on alle viisi, tai palautetta antaneiden opiskelijoiden lista on poissa käytöstä koulutusohjelman asetuksissa", "studentsList": "Palautteen antaneet opiskelijat" }, diff --git a/src/client/pages/FeedbackTarget/tabs/StudentsWithFeedback/StudentsWithFeedback.js b/src/client/pages/FeedbackTarget/tabs/StudentsWithFeedback/StudentsWithFeedback.js index e785b085b..3a3782e47 100644 --- a/src/client/pages/FeedbackTarget/tabs/StudentsWithFeedback/StudentsWithFeedback.js +++ b/src/client/pages/FeedbackTarget/tabs/StudentsWithFeedback/StudentsWithFeedback.js @@ -7,15 +7,15 @@ import StudentTable from './StudentTable' import useStudentsWithFeedback from '../../../../hooks/useStudentsWithFeedback' import { LoadingProgress } from '../../../../components/common/LoadingProgress' import { useFeedbackTargetContext } from '../../FeedbackTargetContext' -import feedbackTargetIsOpen from '../../../../util/feedbackTargetIsOpen' +import feedbackTargetIsEnded from '../../../../util/feedbackTargetIsEnded' -const NoFeedbackAlert = ({ isOpen }) => { +const NoFeedbackAlert = ({ isEnded }) => { const { t } = useTranslation() return ( - {isOpen ? t('studentsWithFeedback:cannotShowWhenOpen') : t('studentsWithFeedback:noFeedbackInfo')} + {isEnded ? t('studentsWithFeedback:noFeedbackInfo') : t('studentsWithFeedback:cannotShowBeforeFeedbackEnds')} ) @@ -25,7 +25,7 @@ const StudentsWithFeedback = () => { const { id } = useParams() const { feedbackTarget } = useFeedbackTargetContext() - const isOpen = feedbackTargetIsOpen(feedbackTarget) + const isEnded = feedbackTargetIsEnded(feedbackTarget) const { students, isLoading } = useStudentsWithFeedback(id) @@ -35,7 +35,7 @@ const StudentsWithFeedback = () => { return ( <> - {!feedbackStatusAvailable && } + {!feedbackStatusAvailable && } )