Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show the same set of fields per record type #229

Closed
tijmenbaarda opened this issue Oct 4, 2024 · 3 comments · Fixed by #238
Closed

Always show the same set of fields per record type #229

tijmenbaarda opened this issue Oct 4, 2024 · 3 comments · Fixed by #238
Assignees

Comments

@tijmenbaarda
Copy link
Contributor

No description provided.

@jgonggrijp
Copy link
Member

I think you mean when displaying a record in the frontend?

@tijmenbaarda
Copy link
Contributor Author

Yes! Both in the table view and the list view a fixed set of fields should be shown. This should probably be the fields as defined in the record ontology. Currently the table view shows all fields that are present in one or more records, and the detail view only shows the fields that are present in that particular record.

In the table view some fields may be hidden by default, but they should always be defined.

This is per Jeroen's request, because he wants to be able to annotate fields that are not filled in.

@jgonggrijp
Copy link
Member

@tijmenbaarda in #233 (review):

What I meant with #229 (and maybe I had not formulated it clearly) was also to show only the fields that belong to the specific record type (like extent, which would only show on BibliographicalRecord). However, I think that the code in this PR prepares well for this with the functions in tabulator-utils.js.

Do you mean you also want to exclude the only-biographical fields from the hidden-but-available columns in the tabulator view of an only-bibliographical catalog (and vice versa)? Because in that case we need a way to distinguish between only-biographical, only-bibliographical and mixed catalogs. Likewise for collections.

Writing this out, I realize this probably isn't worth the effort. We can still do it for the record detail view, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants