Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests not working anymore after Node > 18 #851

Open
Fuzzyma opened this issue Nov 21, 2024 · 0 comments
Open

Tests not working anymore after Node > 18 #851

Fuzzyma opened this issue Nov 21, 2024 · 0 comments
Labels

Comments

@Fuzzyma
Copy link

Fuzzyma commented Nov 21, 2024

Installing this repository has some challenges.
The engine field is set to Node >12. However, Node 12 cant be used because some dependencies at least require Node 14.
In Node 20 the tests start failing because mockFS is not mocking the file system anymore.

So we probably want to set the engine field to Node version 14.21.3 til 18.18.2. I didnt test node 19 since it wasnt LTS but it breaks in Node 20.

I also had problems with yarn versin 3 so I had to install yarn v1 (which by itself is a challenge if corepack is enabled).

So here is what I used in the end:

nvm use 18
npm i yarn # not globally because it conflicts with corepack and corepack will use yarn 3
rm package-lock.json
npx yarn
npx yarn build
npx yarn test

Just leaving this here for others to notice. I am not sure if this package is still relevant for newer node versions but in that case we probably wanna modernice all dependencies

@Fuzzyma Fuzzyma added the bug label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant