Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logr instead of log/slog #103

Open
hiddenmarten opened this issue Dec 15, 2024 · 4 comments
Open

Use logr instead of log/slog #103

hiddenmarten opened this issue Dec 15, 2024 · 4 comments

Comments

@hiddenmarten
Copy link
Contributor

hiddenmarten commented Dec 15, 2024

Describe the feature request

Use logr instead of log/slog

Why do you personally want this feature to be implemented?

#102 (comment)

How long have you been using this project?

No response

Additional information

No response

@hiddenmarten hiddenmarten changed the title Use logr instead of log/slog. Use logr instead of log/slog Dec 15, 2024
@hiddenmarten
Copy link
Contributor Author

Thank you for suggesting this library - I appreciate the opportunity to explore it. I gave it a try and found that it currently doesn't seem to support logs in JSON format, which is something I was hoping for in our use case.

If there’s a workaround or something I might have missed, I’d be happy to revisit it.

@TwiN
Copy link
Owner

TwiN commented Dec 16, 2024

Oh I was suggesting you implement it in the library itself (if you were up to the challenge).

Again, though, only if you're up for it. If not, ill pick this up when I have some time

@hiddenmarten
Copy link
Contributor Author

Thank you for considering me, but I don’t feel confident enough to take on this challenge.

I truly appreciate this project and would love to contribute since I’m also a user. However, improving the logr library is beyond the scope of this project.

@TwiN
Copy link
Owner

TwiN commented Dec 20, 2024

No worries :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants