You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some of these are probably outdated, given that our Julia compat is now at 1.10. But more saliently: the filters are probably not doing what we might like them to do (at least with the current version of Documenter). See https://documenter.juliadocs.org/stable/man/doctests/#Filtering-Doctests
To use a single example,
# Older versions will show "Array{...,1}" instead of "Vector{...}".r"(Array{.+,\s?1}|Vector{.+})",
What we probably want here is to replace Array{...,1} with Vector{...} when performing the doctests, so as per the Documenter docs, I think the filter should be
r"(Array{(.+),\s?1}" => s"Vector{\1})",
Instead, what the current filter does is to simply remove any lines which match the regex. This means any line of output in the doctests that contains either Array{...,1} or Vector{...} is simply ignored, which leads to false test successes.
Although note that the regex+substitution pair can't be specified as part of the call to doctest(). They have to be specified for each test individually. JuliaDocs/Documenter.jl#2360
The text was updated successfully, but these errors were encountered:
DynamicPPL.jl/test/runtests.jl
Lines 93 to 110 in 6657441
Some of these are probably outdated, given that our Julia compat is now at 1.10. But more saliently: the filters are probably not doing what we might like them to do (at least with the current version of Documenter). See https://documenter.juliadocs.org/stable/man/doctests/#Filtering-Doctests
To use a single example,
What we probably want here is to replace
Array{...,1}
withVector{...}
when performing the doctests, so as per the Documenter docs, I think the filter should beInstead, what the current filter does is to simply remove any lines which match the regex. This means any line of output in the doctests that contains either
Array{...,1}
orVector{...}
is simply ignored, which leads to false test successes.Although note that the regex+substitution pair can't be specified as part of the call to
doctest()
. They have to be specified for each test individually. JuliaDocs/Documenter.jl#2360The text was updated successfully, but these errors were encountered: