Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScrollingCarousel does not respond to click sometimes #78

Open
3 tasks done
jeremylin8 opened this issue Apr 22, 2022 · 5 comments
Open
3 tasks done

ScrollingCarousel does not respond to click sometimes #78

jeremylin8 opened this issue Apr 22, 2022 · 5 comments
Labels
enhancement New feature or request

Comments

@jeremylin8
Copy link

Describe the bug

Hello,

I spot this bug when using ScrollingCarousel component. Sometimes, when click on an item, it doesn't respond to the click event. I think it's caused by the mouseMove and mouseDown event both fired. Could you please take a look at this and fix if that's possible? Thank you so much.

Reproduction

Screen.Recording.2022-04-22.at.10.50.01.AM.mov

System Info

System:
    OS: macOS 11.5.1
    CPU: (8) arm64 Apple M1
    Memory: 100.41 MB / 8.00 GB
    Shell: 5.8 - /bin/zsh
  Binaries:
    Node: 16.10.0 - /opt/homebrew/bin/node
    Yarn: 1.22.17 - /opt/homebrew/bin/yarn
    npm: 7.24.0 - /opt/homebrew/bin/npm
  Browsers:
    Chrome: 100.0.4896.127
    Firefox: 98.0
    Safari: 14.1.2
  npmPackages:
    @trendyol-js/react-carousel: ^2.0.1 => 2.0.1

Used Package Manager

npm

Logs

No response

Validations

@hasangenc0
Copy link
Contributor

@jeremylin8 did you try the triggerClickOn prop? if you set triggerClickOn={10} it will trigger click events even if you move your mouse 10px. (you should update the version v3.0.0-beta.4)

@jeremylin8
Copy link
Author

@hasangenc0 I think triggerClickOn prop is only in Carousel component. Can you guys please add it to the ScrollingCarousel component as well?

@hasangenc0 hasangenc0 added the enhancement New feature or request label Apr 25, 2022
@hasangenc0
Copy link
Contributor

I think we can. let's see if we have free time to do it this week.

@jeremylin8
Copy link
Author

Hey @hasangenc0, any updates on this feature? Thanks a lot!

@GautamGupta
Copy link

+1. Running into the same issue with ScrollingCarousel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants