Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establishing Error Page Structure #61

Closed
aahmetcakir opened this issue Jan 19, 2024 · 3 comments · Fixed by #78
Closed

Establishing Error Page Structure #61

aahmetcakir opened this issue Jan 19, 2024 · 3 comments · Fixed by #78
Assignees
Labels
app: client Client project folder good first issue Good for newcomers type: feature New feature or request

Comments

@aahmetcakir
Copy link
Contributor

aahmetcakir commented Jan 19, 2024

Tasks

Establishing Error Page Structure

Why do we need this?

When a user encounters an error, we aim to avoid directing them to the 'next' error page. Instead, we prefer to present commonly used and simple 404 and 500 pages, rather than exposing the error directly to the user.

Implementation Considerations

  • Pay attention to the use of CSS variables in the codebase.
  • Ensure proper naming conventions for properties such as color, font-size, or font-weight when adding them to the variable.scss file.

Design Link

View Design

Questions or Issues

If you still have questions, feel free to comment within the relevant issue. You can tag @armagandalkiran and @aahmetcakir for assistance.

@aahmetcakir aahmetcakir added the type: feature New feature or request label Jan 19, 2024
@aahmetcakir aahmetcakir changed the title Error pages Establishing Error Page Structure Jan 19, 2024
@armagandalkiran armagandalkiran added this to the New UI Development milestone Jan 19, 2024
@armagandalkiran armagandalkiran added app: client Client project folder epic: landing page Landing page epic and removed epic: landing page Landing page epic labels Jan 19, 2024
@armagandalkiran armagandalkiran added the good first issue Good for newcomers label Jan 27, 2024
@hsglc
Copy link
Contributor

hsglc commented Jan 29, 2024

@armagandalkiran Is the design given above only for 404 pages? It seems like the design of the error page should be different?

@armagandalkiran
Copy link
Collaborator

We thought that we proceed with the same UI, different status code for two errors. @aahmetcakir right ?

@aahmetcakir
Copy link
Contributor Author

That's right kardo. We can continue with same UI. @hsglc fyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app: client Client project folder good first issue Good for newcomers type: feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants