From 4915946d68dedb253f95f980d0fbb2843b34fbee Mon Sep 17 00:00:00 2001 From: "adem.ekici" Date: Mon, 16 Dec 2024 19:18:43 +0300 Subject: [PATCH] fix: readme and lint --- README.md | 10 +++++----- kafka/rejection_log_sink_response_handler.go | 2 +- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/README.md b/README.md index 15e74f8..560a2f5 100644 --- a/README.md +++ b/README.md @@ -133,9 +133,9 @@ Check out on [go-dcp](https://github.com/Trendyol/go-dcp#configuration) ## Exposed metrics -| Metric Name | Description | Labels | Value Type | +| Metric Name | Description | Labels | Value Type | |-------------------------------------------------------|----------------------------------------|--------|------------| -| cbgo_kafka_connector_latency_ms_current | Time to adding to the batch. | N/A | Gauge | +| cbgo_kafka_connector_latency_ms_current | Time to adding to the batch. | N/A | Gauge | | cbgo_kafka_connector_batch_produce_latency_ms_current | Time to produce messages in the batch. | N/A | Gauge | You can also use all DCP-related metrics explained [here](https://github.com/Trendyol/go-dcp#exposed-metrics). @@ -143,9 +143,9 @@ All DCP-related metrics are automatically injected. It means you don't need to d ## Breaking Changes -| Date taking effect | Date announced | Change | How to check | -|--------------------|-------------------|--------------------------------|-----------------| -| November 11, 2023 | November 11, 2023 | Creating connector via builder | Compile project | +| Date taking effect | Date announced | Change | How to check | +|--------------------| ---- |---- |-----------------| +| November 11, 2023 | November 11, 2023 | Creating connector via builder | Compile project | ## Grafana Metric Dashboard diff --git a/kafka/rejection_log_sink_response_handler.go b/kafka/rejection_log_sink_response_handler.go index ddb8f22..b56140d 100644 --- a/kafka/rejection_log_sink_response_handler.go +++ b/kafka/rejection_log_sink_response_handler.go @@ -3,6 +3,7 @@ package kafka import ( "context" "fmt" + "github.com/Trendyol/go-dcp-kafka/config" "github.com/Trendyol/go-dcp-kafka/kafka/message" "github.com/Trendyol/go-dcp/logger" @@ -24,7 +25,6 @@ func (r *RejectionLogSinkResponseHandler) OnInit(ctx *SinkResponseHandlerInitCon r.Topic = ctx.Config.RejectionLog.Topic err := r.KafkaClient.CheckTopics([]string{r.Topic}) - if err != nil { logger.Log.Error("error while rejection topic exist request, err: %v", err) panic(err)