1158: AWS version of JShell #1161
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajkumar
force-pushed
the
1158-aws-jshell
branch
8 times, most recently
from
dfe03d0 to
24c59b9
Compare
Open
surajkumar
force-pushed
the
1158-aws-jshell
branch
11 times, most recently
from
f3cf468 to
0d7d787
Compare
ankitsmt211
reviewed
Sep 13, 2024
Comment on lines
+57
to
+64
| if (input == null || input.getAsString().isEmpty()) { | ||
| EmbedBuilder eb = new EmbedBuilder(); | ||
| eb.setDescription(member.getAsMention() | ||
| + ", you forgot to provide the code for JShell to evaluate or it was too short!\nTry running the command again and make sure to select the code option"); | ||
| eb.setColor(Color.ORANGE); | ||
| event.replyEmbeds(eb.build()).queue(); | ||
| return; | ||
| } |
There was a problem hiding this comment.
when setting up code as command option, you can set required property to True thus user can't execute the command without passing in something as code to begin with
There was a problem hiding this comment.
Check, but I think true is the default value
There was a problem hiding this comment.
Added it anyway, it enforces readability ig
There was a problem hiding this comment.
I double checked, required is false by default
Since you made code param as mandatory, you no longer need to check for input being null or empty string
application/src/main/java/org/togetherjava/tjbot/features/jshell/aws/JShellAWSCommand.java
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/jshell/aws/JShellAWSCommand.java
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/jshell/aws/JShellService.java
Outdated
Show resolved
Hide resolved
surajkumar
force-pushed
the
1158-aws-jshell
branch
from
0d7d787 to
86fc982
Compare
surajkumar
force-pushed
the
1158-aws-jshell
branch
from
27ecb74 to
b18ac90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new slash command
/jshell-awsand it's accompanying infrastructure.There are 2 parts:
Slash Command
The new
/jshell-awsworks by accepting 1 parametercodewhich is a snippet of Java code the user provides to be evaluated.This command calls the API hosted on AWS and returns the result. At the moment, it's basic and does not compare to the existing
/jshellcommand which has had much more thought put into handling user inputs and outputs.JShell AWS API
A new module has been added to the project called
jshell-aws-backend. This is the complete infrastructure and code for performing the JShell logic in a serverless AWS Lambda and contains the IaC as a CloudFormation template.There is a GitHub action included in the PR which makes deployment a breeze.
#1158
Screenshots
Command
Error messages
Normal code execution