Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITMS-91108: Invalid privacy manifest - The PrivacyInfo.xcprivacy file from the following path is invalid: “Frameworks/TOCropViewController.framework/TOCropViewControllerBundle.bundle/PrivacyInfo.xcprivacy”. #595

Open
devender3110 opened this issue Oct 8, 2024 · 17 comments
Assignees
Labels

Comments

@devender3110
Copy link

The PrivacyInfo.xcprivacy file from the following path is invalid: “Frameworks/TOCropViewController.framework/TOCropViewControllerBundle.bundle/PrivacyInfo.xcprivacy”. In addition to the privacy manifest files in the locations outlined in the documentation, starting November 12, 2024, all privacy manifests you submit must have valid content. Keys and values in any privacy manifest must be in a valid format. For more details about privacy manifest files,

@billylongta
Copy link

billylongta commented Oct 17, 2024

I had the same issue too. Checkout the resource by SPM, and saw the structure of PrivacyInfo.xcprivacy is not correct:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>NSPrivacyTracking</key>
	<false/>
	<key>NSPrivacyTrackingDomains</key>
	<array/>
	<key>NSPrivacyCollectedDataTypes</key>
	<array/>
	<key>NSPrivacyAccessedAPITypes</key>
	<array>
		<dict/>
	</array>
</dict>
</plist>

it should be:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>NSPrivacyTracking</key>
	<false/>
	<key>NSPrivacyTrackingDomains</key>
	<array/>
	<key>NSPrivacyCollectedDataTypes</key>
	<array/>
	<key>NSPrivacyAccessedAPITypes</key>
	<array/>
</dict>
</plist>

@chrishoffman
Copy link

It looks like this was fixed in 2.7.3 https://github.com/TimOliver/TOCropViewController/releases/tag/2.7.3

@aureliendelrue
Copy link

aureliendelrue commented Oct 24, 2024

I also have this error with 2.7.3 today. @TimOliver could you take a look please ? This file should be in a Sources repository no ? (https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/adding_a_privacy_manifest_to_your_app_or_third-party_sdk#4336749)

@aureliendelrue
Copy link

Hi @TimOliver any news ?

@Pbarth
Copy link

Pbarth commented Oct 31, 2024

Same error as @aureliendelrue

@krloz5028
Copy link

Any update?

@lgc1993-CN
Copy link

lgc1993-CN commented Nov 14, 2024

I had the same issue too. Checkout the resource by SPM, and saw the structure of PrivacyInfo.xcprivacy is not correct:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>NSPrivacyTracking</key>
	<false/>
	<key>NSPrivacyTrackingDomains</key>
	<array/>
	<key>NSPrivacyCollectedDataTypes</key>
	<array/>
	<key>NSPrivacyAccessedAPITypes</key>
	<array>
		<dict/>
	</array>
</dict>
</plist>

it should be:

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>NSPrivacyTracking</key>
	<false/>
	<key>NSPrivacyTrackingDomains</key>
	<array/>
	<key>NSPrivacyCollectedDataTypes</key>
	<array/>
	<key>NSPrivacyAccessedAPITypes</key>
	<array/>
</dict>
</plist>

It works! Thanks for the advice.
Now, I'm just waiting for version 2.7.4 to merge it.

@aleksandar-vostic
Copy link

aleksandar-vostic commented Nov 20, 2024

Any ideas when will 2.7.4 with the fix be?

EDIT: Okay, I just targeted the last commit on the main branch, and it passes Apple's review now.

@lgc1993-CN
Copy link

@TimOliver
I saw that v2.7.4 has been tagged. Will it be released soon?

@JunkyTang
Copy link

I also encountered this issue. After upgrading from 2.7.2 to 2.7.3 and submitting again for review, the problem still persists!

@lgc1993-CN
Copy link

I also encountered this issue. After upgrading from 2.7.2 to 2.7.3 and submitting again for review, the problem still persists!

You should update to version 2.7.4, which has been tagged in this repository but has not yet been officially released.

@deacon78
Copy link

deacon78 commented Dec 5, 2024

Hello @TimOliver
I don't even know from what third party package TOCropViewController is a dependency...
So I cannot aim your git to update to 2.7.4.

My Apple submission cannot be accepted until you release this version 2.7.4 OFFICIALLY/

I imagine I'm not the only one affected by this bug.

Why don't you simply fix that simple bug and RELEASE that 2.7.4 ????

@toscalivia83
Copy link

Same problem here

@TimOliver
Copy link
Owner

TimOliver commented Dec 10, 2024

Hi folks! I'm so sorry for the delay! I don't get a lot of free time for open source work these days, but hopefully I can be around a bit more in 2025.

It's been a very chaotic year for me trying to support privacy manifests. Over on IGListKit, we decided that privacy manifests shouldn't be necessary since Apple's implied that only these third party SDKs are required to supply their own manifests.

A big challenge of this particular issue is it's very hard for me to work out if the privacy manifest was even working or not. 2.7.4 was the second attempt at fixing privacy manifest build errors, and so I needed someone to actually confirm in their own builds if it was working or not. Thanks to those in here who confirmed it for me.

2.7.4 was already pushed on CocoaPods and Carthage, so I'm still not 100% sure what the calls to 'release 2.7.4' were specifically regarding.

I've just marked 2.7.4 as the latest release in GitHub. Is that all that was needed? Let me know! Thanks!

@deacon78
Copy link

deacon78 commented Dec 10, 2024

Hello @TimOliver
I am using many SDKs from the list that you linked :

DKImagePickerController
image_picker_ios
package_info_plus
path_provider
path_provider_ios
file_picker
sqflite
Flutter
url_launcher
url_launcher_ios

I have NO idea whose third party SDK from this list above uses TOcropViewController.

EDIT : I have found the solution to target TOCropViewController 2.7.4
In FLUTTER project, there is a file named "podfile" whose path is
<your flutter project>/ios/Podfile
In that file, there must be this line in order to aim for the last version of TOcropViewController :
pod 'DKImagePickerController', '4.3.9'

don't forget to save file.

Now run these commands

flutter clean
flutter pub get

in ios directory : pod install
Then build an archive :
flutter build ipa

Control in Xcode that there is no problem by right-clic on the generated archive and select "privacy report".
This will generate a PDF file in which errors related to privacy files are listed.
If it is empty, then your are good.

@bfricka
Copy link

bfricka commented Dec 12, 2024

pod update TOCropViewController works. Thanks for taking care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests