-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The Getting Started document could be updated for .NET 8 #1912
Comments
Hi Matheus! Nice article! Thanks you!
Not serious! It could be, because we support .NET 6+ only since November'23. Have you ever thought in terms of backward compatibility? If you have intention to contribute, I would ask you update all samples apps too... 🆗 ❔ |
Hello Raman! Thank you!
No, I have not, only on medium.
Thinking about backwards compatibility, I don't think it will be a problem because we don't need to apply everything in the article and almost everything in it works in dotnet 6.
Ok, I'll update the samples apps and the getting started doc. Can you create a new branch for me so I can work on it? |
@MatheusXavier you should fork the repo, then create your own branch in the forked repo. When you are ready, you can from there create a PR. |
@MatheusXavier As @ggnaegi said, you have to fork Ocelot repo and create feature branch in your forked repo. When you'll create a PR this feature ticket will be accepted. Good luck having much inspiration! |
Three months have passed!.. Also I see the feature branch: 1912-update-docs-and-apps-samples FYIThe samples folder was changed much in PR #2045 . |
@MatheusXavier Hello Matheus!
Please note that we have discontinued support for .NET 6 and 7 and we are now migrating Ocelot to .NET 9, with .NET 8 as the major LTS version. Consequently, your issue opened on January 9 has become highly relevant. It appears we need to address the ticket and move it into active progress. Are you still with Ocelot and able to assist us? |
@MatheusXavier commented on Jan 9, 2024
An entire year has passed 🤔 What is a PR number? 🙉 |
Hi @raman-m Unfortunately I didn't have time to implement that, I also switch between job and now I'm not working with Ocelot anymore, thank you for all support but I'm going to close this issue. |
Updating samples/docs is required! |
…ing Started docs (#2244) * Improve Ocelot logger * Fix tests * Refactor Basic sample * Create Basic Configuration sample * Update gettingstarted.rst: Getting Started docs in Introduction * Update AdministrationApi sample * Update Eureka sample * Update GraphQL sample * Update Kubernetes sample * Update OpenTracing sample * Update ServiceDiscovery sample * Update ServiceFabric sample
Doc Update Suggestion
A little while ago I migrated my project to dotnet 8 and I noticed that the Getting Started documentation is a little outdated, for example:
Program
classProgram
class is being declaredProgram
class is implementing theMain
methodWebApplication.CreateBuilder
Not that these points are serious problems, but I believe that the documentation could be updated.
During the migration I I implemented my Main class a little differently and published this article on medium to demonstrate my approach.
I am willing to make a PR if you fine folks think this kind of changes is welcome.
The text was updated successfully, but these errors were encountered: