Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof of concept on property classes #48

Closed
Theodeus opened this issue Sep 19, 2016 · 9 comments
Closed

Proof of concept on property classes #48

Theodeus opened this issue Sep 19, 2016 · 9 comments
Assignees

Comments

@Theodeus
Copy link
Owner

No description provided.

@alexanderwallin
Copy link
Contributor

Could you describe this a bit?

@Theodeus
Copy link
Owner Author

Theodeus commented Dec 9, 2016

@tencircles had an idea for the properties that went way over my head, so we said he could build a PoC to test it out and then we'd take it from there. :)

@mikehelland
Copy link

I think I might have some kind of proof of concept for you.

openmusic.gallery/gauntlet/

If you click on the hamburger menu next to the sine oscillator or drum kit, you can hit "Add FX". You will see the FX of Tuna available as well as an EQ of my own. Maybe a couple additional.

This is done by defining properties very similar to yours. Here's an example:
[
{"property": "automode", "name": "Auto Mode", "type": "options", "options": [false, true]},
{"property": "baseFrequency", "name": "Base Frequency", "type": "slider", "min": 0, "max": 1},
{"property": "lowGain", "name": "EQ Low", "type": "slider", "min": 0, "max": 1.5, transform: "square"},
{"property": "filterType", "name": "Filter Type", "type": "options",
"options": ["lowpass", "highpass", "bandpass", "lowshelf", "highshelf", "peaking", "notch", "allpass"]}
]

Defining these controls for each FX, whether from Tuna or elsewhere, the app treats them the same.

Is that the kind of thing you had in mind?

@Theodeus
Copy link
Owner Author

Whaddoya say, @tencircles?

@mikehelland
Copy link

I started a conversation over here too just to see what else was out there:

https://www.reddit.com/r/webaudio/comments/ajb4yk/is_there_a_standard_for_web_audio_fx_libraries_if/

@Theodeus
Copy link
Owner Author

Theodeus commented Jan 24, 2019

Hm.. reading the discussion, I'm not 100% sure this issue is about the same thing. This is more about the internal workings of tuna, and your discussion is more about a standard way to digest the API's of different effects.

An interesting discussion, indeed, and possibly something tuna could adhere to of the was such a standard. It would most likely happen through some other mechanic than our internal property descriptions though..

@Theodeus
Copy link
Owner Author

I totally understand why you'd think they're about the same thing, though. :) The issue description is seriously lacking in context. Sorry about that!

@mikehelland
Copy link

No problem. I couldn't tell exactly from the description which is why I had to ask.

@Theodeus
Copy link
Owner Author

#47 will be the issue to discuss this, going forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants