Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for the Wiimote controller #1141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add support for the Wiimote controller #1141

wants to merge 1 commit into from

Conversation

mardy
Copy link
Contributor

@mardy mardy commented Jan 29, 2024

Thanks @Fussmatte for the button pictures. The Product IDs added here are those reported by libSDL when running on a Wii.

Fixes: #1136

Legal Stuff:

By submitting this pull request, I confirm that...

  • My changes may be used in a future commercial release of VVVVVV
  • I will be credited in a CONTRIBUTORS file and the "GitHub Friends"
    section of the credits for all of said releases, but will NOT be compensated
    for these changes unless there is a prior written agreement

flibitijibibo
flibitijibibo approved these changes Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@flibitijibibo flibitijibibo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will wait for the the localization team to approve but the technical side lgtm

Daaaav
Daaaav approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@Daaaav Daaaav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well!

@Fussmatte
Copy link
Contributor

On Windows the game isn't picking up on my Wii Remote - I've tried both a native connection and a connection through Dolphin's continuous Wii Remote scanning feature. Is any specific driver required to use the controller in VVVVVV?

InfoTeddy
InfoTeddy suggested changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@InfoTeddy InfoTeddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the Discord server, we have two reports of the button icons being incorrect. For example, B displays as 1.

@mardy
Add support for the Wiimote controller
f3c8764 
Thanks @Fussmatte for the button pictures. The Product IDs added here
are those reported by libSDL when running on a Wii.

Fixes: TerryCavanagh#1136
@mardy
Copy link
Contributor Author

mardy commented Jan 30, 2024

On the Discord server, we have two reports of the button icons being incorrect. For example, B displays as 1.

That's because the buttons are reported differently on a PC and on a Wii. I've added a PC-specific layout, can you please ask those players to test this new patch?

@flibitijibibo
Copy link
Collaborator

This might be worth punting to SDL, we're supposed to have a hidapi backend for Wii at this point...

https://github.com/libsdl-org/SDL/blob/main/src/joystick/hidapi/SDL_hidapi_wii.c

... but if we're not aligned with the actual Wii port of SDL then we might need to sync those configs up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@InfoTeddy InfoTeddy InfoTeddy requested changes

@Daaaav Daaaav Daaaav approved these changes

@flibitijibibo flibitijibibo flibitijibibo approved these changes

Assignees
No one assigned
Labels
enhancement SDL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wiimote support
5 participants
@mardy @Fussmatte @flibitijibibo @Daaaav @InfoTeddy