Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Docs link for rough notes on catalog converter #6

Open
soyarsauce opened this issue Jul 29, 2020 · 1 comment
Open

Google Docs link for rough notes on catalog converter #6

soyarsauce opened this issue Jul 29, 2020 · 1 comment

Comments

@soyarsauce
Copy link
Contributor

soyarsauce commented Jul 29, 2020

Google Docs link for rough notes on catalog converter

https://docs.google.com/document/d/100dDRrTqNV_azwENxkFiJ-5h8L6mWEJJUOFdAB4cv4M/edit?usp=sharing

Points/comments to be broken down/copied into relevant tickets

@tephenavies
Copy link
Member

tephenavies commented Nov 23, 2020

Copied from Google doc:

How do we make catalog converter v7 -> v8
Need a way to let it run multiple times (in the process of development) as it will be improved on iteratively e.g. new catalog item types
Fixing share will fix most of v7->v8 stories

Problems with

Needs a way to resolve v7 share data into v8:
All v7 catalog definition can be turned into user stratum data, can put this through the catalog converter to handle
To do this, we need to figure out how v7 references a given catalog item?

There inconsistencies with behaviour of ids across v7 and v8
In version 7 Terria merges catalog members that are side-by-side that have matching names (or ids). The matching is kind-of unintuitive though and should be researched
We will re-implement this in v8 TerriaJS/terriajs#4938
E.g. https://github.com/TerriaJS/drought-map/blob/master/datasources/mergeRecursive.js

Maybe we should add ids to everything as they’re converted
Run mergeRecursive first

Where should the share converter run?
In terriajs-server is probably neater
At least with share links we have a version number (previously 0.0.05 and now 8.0.0)
If we put it in terriajs-server, we won’t be able to load version 7 catalogues
Do we want to allow loading version 7 catalogues?
If we did, we’d probably include a disclaimer that it might not work and link to our catalogue converter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants