Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Videos with extremely long titles cannot be downloaded due to character count in filename #11820

Open
6 tasks done
br1anw opened this issue Dec 23, 2024 · 4 comments
Open
6 tasks done
Labels
bug Issue is related to a bug downloader Issue is related to the downloader

Comments

@br1anw
Copy link

br1anw commented Dec 23, 2024

Checklist

  • I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.27.4

Steps to reproduce the bug

Find a video with an extremely long character count.
Upon download request, the only way to download the video is to delete around 5 characters in the "save as" file name.

This is more of an inconvenience, but is it possible to have an option to automatically LIMIT the resulting file name in the settings so that it will automatically truncate an extremely long titled video? The youtube limit for a title seems to be about 5 characters longer than what I assume is the maximum amount of characters allowed in an Android file name- as in the maximum allowed characters in any resulting file created.

Expected behavior

For Newpipe to automatically truncate the file name to be generated in the android file system of those videos with such long titles.

Actual behavior

The file would refuse to be downloaded. Error in NewPipe. I ANSWERED the problem and solution itself. Please consider truncating these filenames maybe as a new setting to automatically truncate to maximum allowed character limit so the user does not need to manually delete 5 to 10 characters to allow the file to be downloaded. This is a convenience worth having.

Screenshots/Screen recordings

None

Logs

None

Affected Android/Custom ROM version

Android 12

Affected device model

Google Pixel 3

Additional information

None

@br1anw br1anw added bug Issue is related to a bug needs triage Issue is not yet ready for PR authors to take up labels Dec 23, 2024
@ShareASmile
Copy link
Collaborator

Can you try settings > download > allowed characters in file names > letters and digits

@ShareASmile ShareASmile added waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. downloader Issue is related to the downloader and removed needs triage Issue is not yet ready for PR authors to take up labels Dec 23, 2024
@br1anw
Copy link
Author

br1anw commented Dec 23, 2024

Nope. Tried toggling both. The characters are standard, with letters and spaces only. The video poster just made extremely long description. They are chinese letters but it should not affect the reason that it is just too long.

I understand by code design perhaps such an option to auto truncate and delete a few letters may not be consistent but there are many files on youtube with such a maximized number of characters utilized to max out the search value rather than putting all that inside the detailed description of the video.

I tried both none and a dash for replacement character and toggled the special character off and on to no avail. Why not have newpipe detect that it is too long to support saving file in android and omitting 5 characters at the end of the file?

@github-actions github-actions bot removed the waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. label Dec 23, 2024
@ShareASmile
Copy link
Collaborator

Ok, I have triaged the issue to be a bug in downloading mechanism.

@br1anw

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue is related to a bug downloader Issue is related to the downloader
Projects
None yet
Development

No branches or pull requests

2 participants