Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite: New Comment fragment makes the app crash for comment errors #11728

Open
Profpatsch opened this issue Nov 21, 2024 · 3 comments
Open
Labels
ASAP Issue needs to be fixed as soon as possible bug Issue is related to a bug rewrite Issues and PRs related to rewrite

Comments

@Profpatsch
Copy link
Contributor

Profpatsch commented Nov 21, 2024

Now errors in the comments make the app crash completely (https://soundcloud.com/user-722618400/a-real-playa):

Exception

  • User Action: ui error
  • Request: ACRA report
  • Content Country: GB
  • Content Language: en-GB
  • App Language: en_GB
  • Service: none
  • Version: 0.27.2
  • OS: Linux Android 13 - 33
Crash log

java.lang.IllegalArgumentException: Page doesn't contain an URL
	at org.schabi.newpipe.extractor.services.soundcloud.extractors.SoundcloudCommentsExtractor.getPage(SoundcloudCommentsExtractor.java:44)
	at org.schabi.newpipe.extractor.comments.CommentsInfo.getMoreItems(CommentsInfo.java:79)
	at org.schabi.newpipe.paging.CommentsSource$load$info$1.invokeSuspend(CommentsSource.kt:23)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:101)
	at kotlinx.coroutines.internal.LimitedDispatcher$Worker.run(LimitedDispatcher.kt:113)
	at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:89)
	at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:589)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:823)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:720)
	at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:707)
	Suppressed: kotlinx.coroutines.internal.DiagnosticCoroutineContextException: [LazyStandaloneCoroutine{Cancelling}@16d25a5, Dispatchers.Main.immediate]


Originally posted by @Stypox in #11060 (comment)

@Profpatsch Profpatsch added bug Issue is related to a bug ASAP Issue needs to be fixed as soon as possible rewrite Issues and PRs related to rewrite labels Nov 21, 2024
@Profpatsch Profpatsch changed the title New Comment fragment makes the app crash for comment errors Rewrite: New Comment fragment makes the app crash for comment errors Nov 21, 2024
@Profpatsch
Copy link
Contributor Author

Can reproduce

@Profpatsch
Copy link
Contributor Author

It seems to be a bug in the extractor for Soundcloud comments; nonetheless we should show an empty comment section instead of crashing the app.

@Stypox
Copy link
Member

Stypox commented Nov 21, 2024

Yes, we should do #11716 and show the error nicely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ASAP Issue needs to be fixed as soon as possible bug Issue is related to a bug rewrite Issues and PRs related to rewrite
Projects
Status: No status
Development

No branches or pull requests

2 participants