Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Do not index translations on default language fallbackType: free #3785

Merged
merged 2 commits into from
Sep 19, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions Classes/Access/RootlineElementFormatException.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,4 @@
*
* @author Ingo Renner <[email protected]>
*/
class RootlineElementFormatException extends InvalidArgumentException
{
}
class RootlineElementFormatException extends InvalidArgumentException {}
3 changes: 1 addition & 2 deletions Classes/Backend/SettingsPreviewOnPlugins.php
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ class SettingsPreviewOnPlugins

public function __construct(
protected FlexFormService $flexFormService
) {
}
) {}

public function __invoke(PageContentPreviewRenderingEvent $event): void
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,4 @@
/**
* Exception that is thrown if the record of the root page couldn't be found
*/
class RootPageRecordNotFoundException extends Exception
{
}
class RootPageRecordNotFoundException extends Exception {}
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,4 @@
/**
* Delayed processing finished event
*/
class DelayedProcessingFinishedEvent extends AbstractProcessingFinishedEvent
{
}
class DelayedProcessingFinishedEvent extends AbstractProcessingFinishedEvent {}
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,4 @@
/**
* Delayed processing queuing finished event
*/
class DelayedProcessingQueuingFinishedEvent extends AbstractProcessingFinishedEvent
{
}
class DelayedProcessingQueuingFinishedEvent extends AbstractProcessingFinishedEvent {}
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,4 @@
/**
* Processing finished event
*/
class ProcessingFinishedEvent extends AbstractProcessingFinishedEvent
{
}
class ProcessingFinishedEvent extends AbstractProcessingFinishedEvent {}
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,4 @@
/**
* Event fired if a record is deleted
*/
class RecordDeletedEvent extends AbstractDataUpdateEvent
{
}
class RecordDeletedEvent extends AbstractDataUpdateEvent {}
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,4 @@
/**
* Event fired if a record garbage check is triggered
*/
class RecordGarbageCheckEvent extends AbstractDataUpdateEvent
{
}
class RecordGarbageCheckEvent extends AbstractDataUpdateEvent {}
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,4 @@
/**
* Event fired if a record is moved
*/
class RecordMovedEvent extends AbstractDataUpdateEvent
{
}
class RecordMovedEvent extends AbstractDataUpdateEvent {}
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,4 @@
/**
* Event fired if a record is created or updated
*/
class RecordUpdatedEvent extends AbstractDataUpdateEvent
{
}
class RecordUpdatedEvent extends AbstractDataUpdateEvent {}
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,4 @@
/**
* Event fired if a version is swapped
*/
class VersionSwappedEvent extends AbstractDataUpdateEvent
{
}
class VersionSwappedEvent extends AbstractDataUpdateEvent {}
3 changes: 1 addition & 2 deletions Classes/Domain/Search/ApacheSolrDocument/Builder.php
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ class Builder
{
public function __construct(
protected readonly IdBuilder $variantIdBuilder
) {
}
) {}

/**
* This method can be used to build a Document from a TYPO3 page.
Expand Down
4 changes: 1 addition & 3 deletions Classes/Domain/Search/Query/SearchQuery.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,4 @@

namespace ApacheSolrForTypo3\Solr\Domain\Search\Query;

class SearchQuery extends Query
{
}
class SearchQuery extends Query {}
3 changes: 1 addition & 2 deletions Classes/Domain/Search/ResultSet/Facets/AbstractFacet.php
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ public function __construct(
protected string $field,
protected string $label = '',
protected array $facetConfiguration = []
) {
}
) {}

/**
* Returns facet name
Expand Down
3 changes: 1 addition & 2 deletions Classes/Domain/Search/ResultSet/Facets/AbstractFacetItem.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ public function __construct(
protected int $documentCount = 0,
protected bool $selected = false,
protected array $metrics = []
) {
}
) {}

public function getDocumentCount(): int
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,4 @@

use ApacheSolrForTypo3\Solr\Exception;

class InvalidFacetPackageException extends Exception
{
}
class InvalidFacetPackageException extends Exception {}
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,4 @@

use ApacheSolrForTypo3\Solr\Exception;

class InvalidFacetParserException extends Exception
{
}
class InvalidFacetParserException extends Exception {}
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,4 @@

use ApacheSolrForTypo3\Solr\Exception;

class InvalidQueryBuilderException extends Exception
{
}
class InvalidQueryBuilderException extends Exception {}
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,4 @@

use ApacheSolrForTypo3\Solr\Exception;

class InvalidUrlDecoderException extends Exception
{
}
class InvalidUrlDecoderException extends Exception {}
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,4 @@
* @author Frans Saris <[email protected]>
* @author Timo Hund <[email protected]>
*/
class NodeCollection extends AbstractFacetItemCollection
{
}
class NodeCollection extends AbstractFacetItemCollection {}
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,4 @@
* @author Frans Saris <[email protected]>
* @author Timo Hund <[email protected]>
*/
class NumericRangeCollection extends AbstractFacetItemCollection
{
}
class NumericRangeCollection extends AbstractFacetItemCollection {}
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,4 @@
/**
* The GroupItemCollection contains the GroupItem objects.
*/
class GroupItemCollection extends AbstractCollection
{
}
class GroupItemCollection extends AbstractCollection {}
3 changes: 1 addition & 2 deletions Classes/Domain/Search/Score/Score.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,7 @@ public function __construct(
protected string $fieldName = '',
protected float $score = 0.0,
protected string $searchTerm = '',
) {
}
) {}

public function getBoost(): float
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,4 @@

use ApacheSolrForTypo3\Solr\Exception;

class InvalidSiteConfigurationCombinationException extends Exception
{
}
class InvalidSiteConfigurationCombinationException extends Exception {}
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,4 @@

use ApacheSolrForTypo3\Solr\Exception;

class InvalidSiteRootPageException extends Exception
{
}
class InvalidSiteRootPageException extends Exception {}
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,4 @@

use ApacheSolrForTypo3\Solr\Exception;

class UnexpectedTYPO3SiteInitializationException extends Exception
{
}
class UnexpectedTYPO3SiteInitializationException extends Exception {}
3 changes: 1 addition & 2 deletions Classes/Domain/Variants/IdBuilder.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ class IdBuilder
{
public function __construct(
protected readonly EventDispatcherInterface $eventDispatcher
) {
}
) {}

/**
* This method is used to build a variantId.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ public function __construct(
private readonly string $type,
private readonly array $indexingConfiguration,
private bool $isInitialized
) {
}
) {}

public function getInitializer(): AbstractInitializer
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ public function __construct(
private readonly int $forcedChangeTime,
private int $updateCount,
private ?array $validLanguageUids
) {
}
) {}

public function getItemType(): string
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,7 @@ public function __construct(
private readonly string $table,
private readonly array $uids,
private array $records
) {
}
) {}

public function getTable(): string
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ public function __construct(
protected readonly int $languageId,
protected readonly string $mountPointParameter,
protected readonly array $options
) {
}
) {}

public function getItem(): Item
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@ public function __construct(
private readonly SiteLanguage $siteLanguage,
private readonly array $record,
private readonly TypoScriptConfiguration $configuration
) {
}
) {}

public function getDocument(): Document
{
Expand Down
3 changes: 1 addition & 2 deletions Classes/Event/Indexing/BeforeDocumentsAreIndexedEvent.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ public function __construct(
private readonly Item $indexQueueItem,
/** @var Document[] */
private array $documents,
) {
}
) {}

public function getSite(): Site
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ public function __construct(
private readonly SearchRequest $searchRequest,
private readonly Search $search,
private readonly TypoScriptConfiguration $typoScriptConfiguration
) {
}
) {}

public function getSearchResultSet(): SearchResultSet
{
Expand Down
3 changes: 1 addition & 2 deletions Classes/Event/Search/AfterSearchHasBeenExecutedEvent.php
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ public function __construct(
private readonly SearchRequest $searchRequest,
private readonly Search $search,
private readonly TypoScriptConfiguration $typoScriptConfiguration
) {
}
) {}

public function getSearchResultSet(): SearchResultSet
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ public function __construct(
private readonly SearchRequest $searchRequest,
private readonly Search $search,
private readonly TypoScriptConfiguration $typoScriptConfiguration
) {
}
) {}

public function getQuery(): Query
{
Expand Down
3 changes: 1 addition & 2 deletions Classes/Event/Variants/AfterVariantIdWasBuiltEvent.php
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,7 @@ public function __construct(
private readonly array $itemRecord,
private readonly Site $site,
private readonly Document $document
) {
}
) {}

public function getVariantId(): string
{
Expand Down
4 changes: 1 addition & 3 deletions Classes/Exception.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,4 @@
/**
* Generic Apache Solr for TYPO3 exception
*/
class Exception extends \Exception
{
}
class Exception extends \Exception {}
4 changes: 1 addition & 3 deletions Classes/Exception/InvalidArgumentException.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,4 @@
/**
* Exception that is thrown if a given argument is invalid.
*/
class InvalidArgumentException extends Exception
{
}
class InvalidArgumentException extends Exception {}
4 changes: 1 addition & 3 deletions Classes/FrontendEnvironment/Exception/Exception.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,4 @@
* Exception that is thrown on initialization of EXT:solr FrontendEnvironment.
* This exception should be used for any errors on indexing .
*/
class Exception extends ExtSolrException
{
}
class Exception extends ExtSolrException {}
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,4 @@
/**
* Exception that is thrown on TYPO3 side in indexing process.
*/
class DocumentPreparationException extends IndexingException
{
}
class DocumentPreparationException extends IndexingException {}
4 changes: 1 addition & 3 deletions Classes/IndexQueue/Exception/IllegalStateException.php
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,4 @@
/**
* Exception that is thrown on indexing process and any potentially unusual state.
*/
class IllegalStateException extends Exception
{
}
class IllegalStateException extends Exception {}
4 changes: 1 addition & 3 deletions Classes/IndexQueue/Exception/IndexingException.php
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,4 @@
* Exception that is thrown on indexing process. Does not matter on which side, TYPO3 or Apache.
* This exception should be used for any errors on indexing process.
*/
class IndexingException extends Exception
{
}
class IndexingException extends Exception {}
8 changes: 8 additions & 0 deletions Classes/IndexQueue/Indexer.php
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,14 @@ protected function getItemRecordOverlayed(Item $item, int $language): ?array
) {
return null;
}
// skip translated records for default language within "free content mode"-languages
if ($language === 0
&& isset($languageField)
&& (int)($itemRecord[$languageField] ?? null) !== $language
&& $this->isLanguageInAFreeContentMode($item, (int)($itemRecord[$languageField] ?? null))
) {
return null;
}

$pidToUse = $this->getPageIdOfItem($item);

Expand Down
Loading