Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch visit_structure() Error more elegantly #166

Open
PatrickRWright opened this issue Mar 5, 2020 · 3 comments
Open

Catch visit_structure() Error more elegantly #166

PatrickRWright opened this issue Mar 5, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@PatrickRWright
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
visit_structure() only works for fixed visit plans. When it fails, the returned Error is cryptic.

Describe the solution you'd like
Since we can assume that the majority of fails in visit_structure() happens when the visit plan is not fixed we can catch the error and send a more helpful Error. e.g. "Likely your visit plan is too flexible to be plotted with this function."

Additional context
#155 (comment)

@PatrickRWright PatrickRWright added the enhancement New feature or request label Mar 5, 2020
@PatrickRWright
Copy link
Collaborator Author

@aghaynes you want to do this before 1.0.0 or can I label is as after 1.0.0 for now? I don't think its a pressing issue.

@aghaynes
Copy link
Member

It's probably be better to get it done before, don't you think? it's not clear at all at the moment...

@PatrickRWright
Copy link
Collaborator Author

@aghaynes do you have a timeline? I'd like to try and get the package on CRAN in April if possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants