Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When we say "Jacobian", do we mean the matrix, or its determinant? #759

Open
N-Dekker opened this issue Nov 17, 2022 · 0 comments
Open

When we say "Jacobian", do we mean the matrix, or its determinant? #759

N-Dekker opened this issue Nov 17, 2022 · 0 comments

Comments

@N-Dekker
Copy link
Member

N-Dekker commented Nov 17, 2022

itk::TransformFilter has a member function ComputeSpatialJacobianOn(), which adds the argument "-jacmat", and a member function ComputeDeterminantOfSpatialJacobianOn(), which adds the argument "-jac". So the member function names assume that the term "Jacobian" refers to its matrix, while the command-line interface assumes that "-jac" is about its determinant.

To avoid further confusion, I would prefer to always explicitly specify whether the matrix or its determinant is requested. Which is also why I proposed (with pull request #755) to add ComputeSpatialJacobianDeterminantImage() and ComputeSpatialJacobianMatrixImage().

Regarding the command-line interface, I guess we could do:

-jac mat  ---- write only the image of Jacobian matrices
-jac det  ---- write only the image of Jacobian determinants
-jac all  ---- write both images

Right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant