Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] <title> decky 3.0.4 Delete screenshot pop-up error in game mode #705

Open
3 of 4 tasks
lzq960605 opened this issue Sep 17, 2024 · 29 comments
Open
3 of 4 tasks
Labels
bug Something isn't working

Comments

@lzq960605
Copy link

Please confirm

  • I have searched existing issues
  • This issue is not a duplicate of an existing one
  • I have checked the common issues section in the readme file
  • I have attached logs to this bug report (failure to include logs will mean your issue may not be responded to).

Bug Report Description

7_5

Expected Behaviour

3.0.0 official version Game mode error ,Steam client is the latest beta version

SteamOS version

steam os 3.6.13

Selected Update Channel

Stable

Decky Loader Version

3.0.0

Plugin Info

deckylog.txt

Have you modified the read-only filesystem at any point?

No response

Backend Logs

deckylog.txt

Frontend Logs

cef_log.previous.txt
cef_log.txt

@lzq960605 lzq960605 added the bug Something isn't working label Sep 17, 2024
@TrainDoctor
Copy link
Member

@lzq960605 please give the latest pre-release a run and see if you continue to encounter this issue.

@lzq960605
Copy link
Author

@lzq960605 please give the latest pre-release a run and see if you continue to encounter this issue.

OK, I'll try.

@lzq960605
Copy link
Author

@lzq960605 please give the latest pre-release a run and see if you continue to encounter this issue.

This issue has not yet been reproduced

@mgnsk
Copy link

mgnsk commented Sep 19, 2024

I still get the error with Decky v3.0.1-pre3. It happens when deleting a screenshot. I think it might be related to Steam's new screenshot UI

@AAGaming00
Copy link
Member

try again without decky, this is probably a steam bug

@mgnsk
Copy link

mgnsk commented Sep 20, 2024

try again without decky, this is probably a steam bug

I selected disable decky until next boot and then I was able to delete screenshots.

@TrainDoctor
Copy link
Member

try again without decky, this is probably a steam bug

I selected disable decky until next boot and then I was able to delete screenshots.

If you can collect CEF logs at performing the actions with decky enabled and decky disabled and distinguish the two we can hopefully trace the issue. Otherwise we can't do much with this information as I've been unable to recreate the issue you've described.

@TrainDoctor
Copy link
Member

try again without decky, this is probably a steam bug

I selected disable decky until next boot and then I was able to delete screenshots.

manged to recreate the issue myself

CEF logs:
cef_log.txt
cef_log.previous.txt

@lzq960605
Copy link
Author

try again without decky, this is probably a steam bug

I selected disable decky until next boot and then I was able to delete screenshots.

It is true that this bug will appear when deleting the screenshots. It will also appear in decky3.0.1. I will try to reproduce it later.

@lzq960605
Copy link
Author

cef_log.previous.txt
cef_log.txt
7_5

Just delete the screenshot to reproduce the bug 100%

@carrot117
Copy link

I have the same issue.This problem arises if the screenshot is deleted.

@lzq960605
Copy link
Author

3.0.2
Screenshot_20241004_183442

@eXhumer
Copy link
Contributor

eXhumer commented Oct 4, 2024

Decky-Recorder_2024-10-01_13-24-35.mp4

Does anyone know how exactly is one supposed to reproduce this? I haven't been able to repro on v3.0.1 or v3.0.2-pre1.

@lzq960605
Copy link
Author

lzq960605 commented Oct 5, 2024

Decky-Recorder_2024-10-01_13-24-35.mp4
Does anyone know how exactly is one supposed to reproduce this? I haven't been able to repro on v3.0.1 or v3.0.2-pre1.

v3.0.2-pre2 fixed this problem, but the latest steam beta client has this problem again

@pchristod
Copy link

I can reproduce this pretty easily as well with latest Beta Release and latest Decky Pre. Take a screenshot ingame, exit game normally, try to open the just snapped Screenshot from the Game Page directly. This will trigger that same error as well each time.

@TrainDoctor
Copy link
Member

I am no longer able to replicate this issue myself. If anyone can replicate it I will continue to keep this issue open.

@lzq960605
Copy link
Author

I am no longer able to replicate this issue myself. If anyone can replicate it I will continue to keep this issue open.

This problem still exists in v3.0.3-pre1
Screenshot_20241014_040257

@eXhumer
Copy link
Contributor

eXhumer commented Oct 13, 2024

Confirmed reproducible with 3.0.3-pre1.

Looking through the component stack trace in Steam Deck, the following two functions from Decky Loader seems to be attaching to the component before erroring.

20241013142124_1

@eXhumer
Copy link
Contributor

eXhumer commented Oct 13, 2024

This is the function inside which it is failing.

        function F(e) {
            const {handle: t, controlsVisible: r, fnOnContentWidth: i} = e
              , a = (0,
            C.FD)(t)
              , [s,o] = (0,
            n.useState)(!1);
            (0,
            n.useEffect)(( () => o(!1)), [t]);
            const c = a.data
              , m = n.useCallback((e => {
                const t = e.target;
                i(t.clientWidth)
            }
            ), [i])
              , u = (0,
            y.wY)(m);
            if (a.isLoading)
                return n.createElement(g.O0, {
                    className: f.FocusedScreenshotSkeleton
                });
            if (a.isError || s)
                return n.createElement(le, {
                    className: f.FocusedScreenshotError
                }, n.createElement(A.Z, {
                    className: f.Message
                }, (0,
                l.we)("#ScreenshotUploader_FailedToLoadScreenshot")));
            const {strUrl: d} = c;
            return n.createElement(g.Kz, {
                direction: "column",
                space: "md",
                grow: !0
            }, n.createElement(A.Z, {
                className: f.FocusedScreenshotContainer
            }, n.createElement("div", {
                className: f.FocusedScreenshotImageContainer
            }, n.createElement("img", {
                ref: u,
                onError: () => o(!0),
                src: d,
                className: f.FocusedScreenshot
            })), n.createElement(G, {
                handle: t,
                screenshot: c,
                key: t,
                controlsVisible: r
            })))
        }

This is the destructing line that fails

            const {strUrl: d} = c;

@Vegas7
Copy link

Vegas7 commented Nov 1, 2024

Decky-Recorder_2024-10-01_13-24-35.mp4
Does anyone know how exactly is one supposed to reproduce this? I haven't been able to repro on v3.0.1 or v3.0.2-pre1.

View the screenshot, then delete it in the viewing mode (or full screen mode?), that will trigger the issue.

@lzq960605
Copy link
Author

lzq960605 commented Nov 6, 2024

decky 3.0.4 ,Steam stable version client,The problem still exists

@lzq960605
Copy link
Author

7_2

@lzq960605
Copy link
Author

@lzq960605 lzq960605 changed the title [BUG] <title> 3.0.0 official version Game mode error [BUG] <title> decky 3.0.4 Delete screenshot pop-up error in game mode Nov 6, 2024
@AAGaming00
Copy link
Member

Confirmed reproducible with 3.0.3-pre1.

Looking through the component stack trace in Steam Deck, the following two functions from Decky Loader seems to be attaching to the component before erroring.

20241013142124_1

those two don't matter, they'll always be there for all routes

@Tariomka
Copy link

Tariomka commented Nov 8, 2024

Same as @lzq960605 mentioned, Decky Loader v3.0.4, SteamOS latest stable version, can be reproduced, disabling Decky Loader doesn't reproduce this issue.

https://streamable.com/1nv5i3

@AAGaming00
Copy link
Member

Same as @lzq960605 mentioned, Decky Loader v3.0.4, SteamOS latest stable version, can be reproduced, disabling Decky Loader doesn't reproduce this issue.

https://streamable.com/1nv5i3

dead link, upload directly to GitHub instead

@Tariomka
Copy link

Same as @lzq960605 mentioned, Decky Loader v3.0.4, SteamOS latest stable version, can be reproduced, disabling Decky Loader doesn't reproduce this issue.
https://streamable.com/1nv5i3

dead link, upload directly to GitHub instead

Sorry, had issues with attaching directly in Github. Here's the reproduction of this issue:

Decky-Recorder_2024-11-15_20-32-42.mp4

It's only reproducible when an image is opened, deleting from options menu works fine.

@lzq960605
Copy link
Author

This bug still exists in v3.0.5-pre1

@TehCrazyCat
Copy link

This bug still exists in todays stable release v3.0.5

And as stated above, only occurs when deleting the screenshot after opening it, options menu works fine.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

10 participants