Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Produce a clean build of Twitter Bootstrap #60

Closed
codylerum opened this issue Dec 20, 2012 · 5 comments
Closed

Produce a clean build of Twitter Bootstrap #60

codylerum opened this issue Dec 20, 2012 · 5 comments
Milestone

Comments

@codylerum
Copy link

Specifically using wro4j with less4j

@SomMeri
Copy link
Owner

SomMeri commented Dec 22, 2012

The list of currently known issues bootstrap compilation depends on (tested with less4j-0.0.7):

These issues currently prevents bootstrap compilation. New issues may be found after we fix them.

@SomMeri
Copy link
Owner

SomMeri commented Jan 2, 2013

Updated list of currently known issues bootstrap compilation depends on (tested with less4j-0.0.8):

@SomMeri
Copy link
Owner

SomMeri commented Feb 7, 2013

Last remaining issue: #90

@SomMeri
Copy link
Owner

SomMeri commented Feb 7, 2013

Tried it after closing #90 and the only differences seems to be:

  • comments locations (less.js puts them on new line while less4j keeps then on original line),
  • empty lines does not match,
  • shorthand 3-character colors vs equivalent 6-character colors,
  • number format .5 vs 0.5,
  • calculated values may differ on 15th decimal place (23.351063829787233% vs 3.351063829787232%).

These things does not influence how css is interpreted, so I', closing.

@SomMeri SomMeri closed this as completed Feb 7, 2013
@alexo
Copy link
Contributor

alexo commented Feb 7, 2013

Great! Can't wait to see new release. By the way, it could have a major number changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants