Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library user should be able to add his own functions #134

Closed
SomMeri opened this issue Mar 27, 2013 · 5 comments
Closed

Library user should be able to add his own functions #134

SomMeri opened this issue Mar 27, 2013 · 5 comments

Comments

@SomMeri
Copy link
Owner

SomMeri commented Mar 27, 2013

No description provided.

@alexo
Copy link
Contributor

alexo commented Aug 30, 2013

There is a question posted on the wro4j mailing list (https://groups.google.com/forum/#!topic/wro4j/QWulX8bTaVI) and I am wondering how this will be implemented in less4j?

@SomMeri
Copy link
Owner Author

SomMeri commented Aug 30, 2013

I planned to add a new customFunctions property to Configuration object and unknown functions would be passed to that object.

The tricky part is to decide how to pass arguments to custom functions:

  • I do not want to expose AstCssNode hierarchy to API, because that would make all refactorings difficult.
  • Passing arguments as String or something similar would be too limiting on the other hand.

@alexo
Copy link
Contributor

alexo commented Aug 30, 2013

But what is the mechanism to evaluate the javascript code on the server-side? Will rhiino be used for that purpose?

@SomMeri
Copy link
Owner Author

SomMeri commented Aug 30, 2013

I planned to allow java implemented functions. The user could then implement them in whatever language he likes and whatever compiler/interpreter for that language he likes.

Offtopic: support for inline javascript is tracked here #22 my take at it here

SomMeri pushed a commit that referenced this issue Mar 19, 2014
SomMeri pushed a commit that referenced this issue Mar 19, 2014
@SomMeri SomMeri added this to the 1.4.2 milestone Mar 19, 2014
@SomMeri
Copy link
Owner Author

SomMeri commented Mar 22, 2014

@SomMeri SomMeri closed this as completed Mar 22, 2014
SomMeri pushed a commit that referenced this issue Mar 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants