Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useExternalResource versus ExternalResource #610

Open
jberdine opened this issue Dec 19, 2024 · 2 comments
Open

useExternalResource versus ExternalResource #610

jberdine opened this issue Dec 19, 2024 · 2 comments
Labels
api-change Public API (breaking) change
Milestone

Comments

@jberdine
Copy link
Contributor

jberdine commented Dec 19, 2024

It is potentially confusing that we have a useExternalResource function that does not necessarily have anything to do with the ExternalResource type, but instead works with ExternalServices.

@jberdine jberdine added the api-change Public API (breaking) change label Dec 19, 2024
@jberdine jberdine added this to the alpha milestone Dec 20, 2024
@jberdine
Copy link
Contributor Author

Maybe it is ok. If useExternalResource is used for a service defined with a GenericExternalService, then an ExternalResource might indeed have been used. On the other hand if useExternalResource is used for a service defined with a SkipExternalService, then there is no ExternalResource involved.

Curious if @bennostein, @beauby, or @pikatchu have opinions.

@bennostein
Copy link
Contributor

for a service defined with a SkipExternalService, then there is no ExternalResource involved.

Indeed there is no ExternalResource but there is an "external resource", i.e. a Resource belonging to the external skip service. I agree it's not perfect, but I can't think of a better name atm...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-change Public API (breaking) change
Projects
None yet
Development

No branches or pull requests

2 participants