Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic versioning #34

Open
TheElan opened this issue Nov 28, 2021 · 4 comments
Open

Automatic versioning #34

TheElan opened this issue Nov 28, 2021 · 4 comments

Comments

@TheElan
Copy link
Collaborator

TheElan commented Nov 28, 2021

It would be nice to have automatic minor or major version bump on each PR. This way nobody needs to remember to tag things.

@SinTh0r4s
Copy link
Owner

Automatically parse Tag and add an incremented to merge commit.
But that will add friction for bumping the major versions manually. It would add a step to remove the current tag to the process. Is there an alternative?

@TheElan
Copy link
Collaborator Author

TheElan commented Nov 28, 2021

Was thinking the same, would be a tad problematic when we want a major version bump. Maybe we can drive this with a convention like always update minor, unless commit message contains [major update] (should be included in PR title so merge commit includes this in it) and script should bump major

@TheElan
Copy link
Collaborator Author

TheElan commented Nov 28, 2021

if somebody misses this thing you could always make dummy commit into master (or a PR with it) to trigger tagging

@SinTh0r4s
Copy link
Owner

SinTh0r4s commented Dec 26, 2021

https://axion-release-plugin.readthedocs.io/en/latest/

So to summarize:

Firstly, we need to check how forge handles funny semver variants to see if we can fool them somehow.

Secondly, to change the versioning of all mods (again!) will require some serious convincing on the staff. They want something working with all mods and be done with it. Not learn another system (the sad truth). So we might need to prepare some good selling points

Thirdly, some people have issues with syncing git tags to master. How could we Adresse that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants