Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolchains not working as expected on Windows #33

Open
TheElan opened this issue Nov 28, 2021 · 2 comments
Open

Toolchains not working as expected on Windows #33

TheElan opened this issue Nov 28, 2021 · 2 comments

Comments

@TheElan
Copy link
Collaborator

TheElan commented Nov 28, 2021

Try to find out what causes wired behaviour, on system where only jre was present and dev used a bundled version of 11th in IDEA there was a problem of gradle not downloading jdk and attempting to use jre.

Running ./gradlew build should ensure proper java setup

Test cases to try out:

  1. No java in the system - should automatically install 8th when
  2. Newer (11th) java in the system - should automatically install 8th when
  3. 8th jre in the system - should install 8th jdk
  4. Newer (11th) jre in the system - should install 8th jdk
  5. Many jdk versions including 8th - should use 8th
  6. Many jdk versions excluding 8th - should install 8th

Fiddle with PATH and JAVA_HOME (empty, present (pointing to java install dir), absent)

@TheElan
Copy link
Collaborator Author

TheElan commented Nov 28, 2021

We might want to consider rolling back to using if-throw exception on gradle evaluation if incorrect java is used (this means you need gradle to run on this java entirely, in comparison toolchain only forces it in some tasks), this way it will fail much faster.

@SinTh0r4s
Copy link
Owner

Yes. I think this is the way to go, untill all forge Gradle tasks can be converted to toolchains from Gradle 6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants