Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rendering of markdown lists is broken #178

Open
Krastanov opened this issue Jul 22, 2023 · 4 comments
Open

rendering of markdown lists is broken #178

Krastanov opened this issue Jul 22, 2023 · 4 comments

Comments

@Krastanov
Copy link
Contributor

I have the following markdown page:

landing = App() do
    content = md"""
    - this should
    - be a normal
    - bullet list
    """
    return DOM.div(JSServe.MarkdownCSS, JSServe.Styling, content)
end;

Instead of rendering as a bullet list, the rendering is broken:

image

Here is the HTML that JSServe generated:

image

If I delete list-style: inside; from the style attribute, things work fine.

@Krastanov
Copy link
Contributor Author

Is there a way for me to tell JSServe to not include the list-style: inside;?

@Krastanov
Copy link
Contributor Author

I am currently using a manually added JSServe.DOM.style("ul {list-style: circle !important;}") as a hacky workaround.

@kongdd
Copy link
Contributor

kongdd commented Jan 5, 2024

I am currently using a manually added JSServe.DOM.style("ul {list-style: circle !important;}") as a hacky workaround.

I have the same issue. But it seems not work for Bonito.jl, with Bonito.DOM.style("ul {list-style: circle !important;}").

@SimonDanisch
Copy link
Owner

This should work:

landing = App() do
    content = md"""
    - this should
    # - be a normal
    - bullet list
    """
    style = DOM.style("""
        li > p {
            display: inline;
        }
    """)
    return DOM.div(Bonito.MarkdownCSS, style, content)
end

We need to re-evaluate why the ul needs the inline style... I know I fixed some annoying issue with that some time ago, but not 100% sure if there aren't better work arounds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants