VS Code extension - Reveal output window on errors

[andyw8]

I noticed the Sorbet extension has this option:

A similar feature may be useful for Ruby LSP.

[vinistock]

I'm not opposed to this, but it does need to be turned off by default. In fact, we were the ones who got in touch with the Sorbet team to turn it off in the Sorbet extension.

It was originally always on, but that was so incredibly annoying that we asked to change it.

[andyw8]

I think it depends on the kinds of errors being reported. If they're just distracting noise, then that would be unhelpful. But perhaps there should be some effort put into reduce those errors.

For the Sorbet extension, do you recall what was causing it?

[vinistock]

It's always server errors and it's controlled by the client options we specify.

I'm strongly against having the default be to open it on errors, it needs to default to never revealing. Essentially, the experience of revealing on error means that you're in the middle of coding and then an LSP error that may be completely irrelevant or transitory will continuously open the output tab - diverting your attention from the work you're currently doing.

Again, I'm not opposed to making it configurable as long as it's off by default, but then I don't know who would actually choose that experience for themselves.

Errors that happen on the server are typically bugs in our implementation, which is of interest to us, but not to the developer using the Ruby LSP. That's why we went with reporting the error to telemetry and printing it to the output tab at the same time, but without revealing anything. It doesn't annoy the user and still lets the people who can actually action on the problems to do so.