Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon Selector very laggy and cpu intensive #316

Open
zhrexl opened this issue Aug 24, 2023 · 1 comment
Open

Icon Selector very laggy and cpu intensive #316

zhrexl opened this issue Aug 24, 2023 · 1 comment
Labels

Comments

@zhrexl
Copy link

zhrexl commented Aug 24, 2023

Describe the Bug

When the icon selector is opened it gets very laggy, its really hard to select an icon. The CPU goes to 100% when scrolling the GtkIconView (Core i7 12700H).

Steps to reproduce the behavior:

  1. Go to Menu Editor
  2. Try to select a new icon for the menu

Here's a sysprof print recording the behaviour
image

Expected Behavior

Not be laggy at all just like others icon selectors.

If more information is needed I can try to gather it.

System

  • Fedora 38
  • GNOME Shell version: 44
@zhrexl zhrexl added the bug label Aug 24, 2023
@Schneegans
Copy link
Owner

Yeah, I know that it can be laggy sometimes. The amount of "lagginess" depends on the icon theme you use. With the default Adwaita icons it's OK on my machine. Bigger icon sets can be more demanding.

However, I think there's no easy fix as the GtkIconView is simply too slow for this use-case. I could rewrite the dialog using a more modern widget such as the GtkGridView but this will make it difficult to remain backward-compatible. When GNOME 45 is released later this year, Fly-Pie will need some severe porting which will drop support for all older GNOME versions anyways. After that, it will be much easier to clean up some of the GTK3 legacy code in the UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants