Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The last line of test_c14n.pl is missing a comma (plus ... is plunit underreporting?) #39

Open
dtonhofer opened this issue Aug 25, 2020 · 1 comment

Comments

@dtonhofer
Copy link

dtonhofer commented Aug 25, 2020

test('3.2.4.2.3 Test case c14n11/xmlbase-c14n11spec-102', [blocked('Cannot express [self::a or ancestor-or-self::d] using builtin xpath')]):-
        c14n_test('testdata/xmlbase-c14n11spec3-input.xml', unknown 'xmlbase-c14n11spec3-102.output').

There should be one after unknown.

Not so bad, you say. Especially as the test is marked "blocked".

However, running the SWI-Prolog test suite does not generate an error here (100% tests passed), although the LastTest.log indeed says:

ERROR: swipl-devel_original/packages/sgml/test_c14n.pl:196:67: Syntax error: Operator expected

(The weirdest thing is that I can't remember seeing this error in the log before ... maybe I'm just getting old).

Additionally, we have the follwoing in the log:

% PL-Unit: c14n ....
ERROR: SGML2PL(xmlns): swipl-devel_original/packages/sgml/testdata/xmlspace-input.xml:4: xml:space-mode "true" does not exist
.
ERROR: SGML2PL(xmlns): swipl-devel_original/packages/sgml/testdata/xmlspace-input.xml:4: xml:space-mode "true" does not exist
.
ERROR: SGML2PL(xmlns): swipl-devel_original/packages/sgml/testdata/xmlspace-input.xml:4: xml:space-mode "true" does not exist
.
ERROR: SGML2PL(xmlns): swipl-devel_original/packages/sgml/testdata/xmlspace-input.xml:4: xml:space-mode "true" does not exist
.......... done

In spite of that:

100% tests passed, 0 tests failed out of 69

Should this really be reported as "100% passed"?

@dtonhofer dtonhofer changed the title The last line of test_c14n.pl is missing a comma (plus ... is the test suite underreporting?) The last line of test_c14n.pl is missing a comma (plus ... is plunit underreporting?) Aug 25, 2020
@JanWielemaker
Copy link
Member

Thanks. Fixed the missing comma after unknown. @thetrime. I don't dare touching these files, but could you comment on "xml:space="true"? Is this really intended? It seems not part of the XML standard, but it is not clear that an XML processor should complain on unknown values for this attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants