Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript errors #38

Open
alexandrumic opened this issue Nov 12, 2020 · 2 comments
Open

Typescript errors #38

alexandrumic opened this issue Nov 12, 2020 · 2 comments

Comments

@alexandrumic
Copy link
Contributor

Hello,

I am having the following errors when I am running typecheck script:

node_modules/react-native-draggable-grid/src/draggable-grid.tsx:100:20 - error TS6133: 'item' is declared but its value is never read.

100     items.forEach((item, index) => {
                       ~~~~

node_modules/react-native-draggable-grid/src/draggable-grid.tsx:123:24 - error TS6133: 'nativeEvent' is declared but its value is never read.

123   function onStartDrag(nativeEvent: GestureResponderEvent, gestureState: PanResponderGestureState) {
                           ~~~~~~~~~~~

node_modules/react-native-draggable-grid/src/draggable-grid.tsx:144:23 - error TS6133: 'nativeEvent' is declared but its value is never read.

144   function onHandMove(nativeEvent: GestureResponderEvent, gestureState: PanResponderGestureState) {
                          ~~~~~~~~~~~


Found 3 errors.

I have a typecheck script defined as ./node_modules/.bin/tsc --noEmit. I've also tried with --skipLibCheck even if in tsconfig.js I have "skipLibCheck": true, and

"exclude": [
    "node_modules",
    ...
  ]

added.

This should ignore errors from node_modules but it seems that I am still receiving the ones from this library.

Do you have some solutions for this?

Thanks

@alexandrumic
Copy link
Contributor Author

Update: I have managed to fix the Typescript errors in #39

@SHISME
Copy link
Owner

SHISME commented Nov 13, 2020

ok,thanks for pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants