Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving volume when swapping clips #56

Open
lars-vc opened this issue Sep 5, 2022 · 3 comments
Open

Saving volume when swapping clips #56

lars-vc opened this issue Sep 5, 2022 · 3 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@lars-vc
Copy link

lars-vc commented Sep 5, 2022

Idea

Currently, the volume doesn't get saved when swapping clips, I think it would be handier to have this saved globally instead of on a clip to clip basis.

Example

I adjust volume in this clip.
image
image
Delete the clip.
image
Put in another clip.
image
And the volume is raise to the default value again.
image

@Rodeoclash Rodeoclash added the enhancement New feature or request label Sep 6, 2022
@Rodeoclash Rodeoclash changed the title [Feat] Saving volume when swapping clips Saving volume when swapping clips Sep 6, 2022
@Rodeoclash
Copy link
Owner

This is an interesting idea - we're basically taking information about the video and storing it outside of the current project. I need to think about this some more, does the app store this information internally? Do we store a file alongside the video which contains information about it?

An existing tool that does something similar is Ableton Live (https://www.ableton.com). When you import a sample into Ableton, it'll create (I think) an .asd file which lives alongside the sample. This asd file contains stored information about the sample.

That said, I do get a bit annoyed about my system getting clogged up with asd files and I'm sure others feel the same way. Ideally it should be stored within the app itself.

@lars-vc - what's the workflow you're using that causes you to unload a video and load it again? Are you sharing one video between multiple projects?

@lars-vc
Copy link
Author

lars-vc commented Sep 7, 2022

I had a couple vods of games I was looking at an skimming through just look at certain points. After I finished the game I removed the vod and dragged in a new one.

Now if I assume correctly a project can be made so that notations and such (and the volume) are saved, maybe its an idea to just keep the last volume if it's a new project, but override it if it's an existing project that has the volume saved.

@Rodeoclash
Copy link
Owner

I just confirmed with someone else that the volume isn't always saving between sessions in the app (with the same clip, if you close and open it again) so there's definitely a bug related to the volume which I'll track in this ticket.

Now if I assume correctly a project can be made so that notations and such (and the volume) are saved, maybe its an idea to just keep the last volume if it's a new project, but override it if it's an existing project that has the volume saved.

I haven't tested saving the project + volume but it should preserve the volume, bookmarks, sync and everything else when you save a project. The volume may be misbehaving here as well as the auto save and project save use the same code.

@Rodeoclash Rodeoclash added the bug Something isn't working label Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants