Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: RC node.js SDK deps use eval statements #154

Open
sidmohanty11 opened this issue Jun 27, 2022 · 1 comment
Open

BUG: RC node.js SDK deps use eval statements #154

sidmohanty11 opened this issue Jun 27, 2022 · 1 comment

Comments

@sidmohanty11
Copy link

I am working on the EmbeddedChat project. I am using Rocket.Chat Nodejs SDK v1.0.0-alpha.42. I've polyfilled all nodejs packages (around 40) which were causing errors when bundling with Rollup. But after that, there was one warning left with use of eval is strongly discouraged, It is coming from js-sha256 package, linked issue.

Can the SDK be modified so that SDK is not limited to the backend and can be used with the frontend also? Else, can js-sha256 be eliminated from this package and use crypto instead?
image
@sidmohanty11 sidmohanty11 changed the title BUG: Bundled RC node.js SDK uses eval statements BUG: RC node.js SDK deps uses eval statements Jun 27, 2022
@sidmohanty11 sidmohanty11 changed the title BUG: RC node.js SDK deps uses eval statements BUG: RC node.js SDK deps use eval statements Jun 27, 2022
@sidmohanty11
Copy link
Author

@diegolmello could you please take a look? We are using js-sha256 as a dependency which is causing this warning. This has been deprecated.

@sidmohanty11 sidmohanty11 mentioned this issue Jun 30, 2022
Open
@sidmohanty11 sidmohanty11 mentioned this issue Jul 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sidmohanty11