Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add edit room information feature #732

Closed

Conversation

abirc8010
Copy link
Contributor

@abirc8010 abirc8010 commented Dec 25, 2024

Brief Title

Allow users with edit permissions to edit room information

Acceptance Criteria fulfillment

  • Add functionality to edit room name, description, topic, and announcement.
  • Implement a modal to display the announcement.
  • Ensure edit option is only visible to users with edit permission

Fixes #731

Video/Screenshots

Screencast.from.2024-12-25.14-54-06.webm

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-732 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@abirc8010 abirc8010 marked this pull request as draft December 25, 2024 09:28
@Spiral-Memory
Copy link
Collaborator

Spiral-Memory commented Dec 25, 2024

Hi @abirc8010 ,

I’m really sorry to say, but this isn’t the intended purpose of EmbeddedChat.

Editing room information and similar actions are not necessary here, as these will be managed remotely by the RC admin. I may have to close this PR, I don't really want anyone's efforts to be wasted, so if you are working on an issue which you are confused about, maybe pls confirm with me or the other maintainers before starting to work on it.

However, I do like the announcement feature! Is it available in Rocket.Chat as well? If yes, please raise a separate PR for it with an improved UI. The current UI for announcement doesn’t look very good.

@abirc8010
Copy link
Contributor Author

Hey @Spiral-Memory , I drew inspiration for the announcement UI from RC. I'd really appreciate your feedback and suggestions on how to enhance it for EC.

Screencast.from.2024-12-25.14-23-07.webm

@Spiral-Memory
Copy link
Collaborator

Switch to light mode in RC and show me how it looks

@abirc8010
Copy link
Contributor Author

image

@Spiral-Memory
Copy link
Collaborator

Alright, try to match the primary colors (don't use any hardcoded colors, you can take help of lighten, darken function in ec to adjust) in EC with the header. Make sure it works well in both light / dark modes and in all prebuilt themes.

Reduce the padding slightly, and don't open the modal on click. Only open the modal when the announcement message doesn't fit in the header (ensure to use an ellipsis style to truncate the extra text).

Also, ensure that a prop can be passed as false to EmbeddedChat to hide the announcement header if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Add room information edit feature
2 participants