Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy certificate authorities in final image #261

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

joselsegura
Copy link
Collaborator

Description

ubi-micro, used as base image, doesn't contain the needed certificate files to be able to connect to external services, causing problems when connecting to logstash (for example).

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Testing steps

Manual tests locally

Checklist

  • make before_commit passes
  • updated documentation wherever necessary
  • added or modified tests if necessary
  • updated schemas and validators in insights-data-schemas in case of input/output change

Copy link
Collaborator

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah Haberdasher :)

LGTM

@codecov-commenter
Copy link

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@joselsegura joselsegura merged commit 68f7108 into master Sep 20, 2023
3 checks passed
@joselsegura joselsegura deleted the certs_in_final_image branch September 20, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants