Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show errors inline #20

Open
Ugoku opened this issue Sep 17, 2019 · 0 comments
Open

Show errors inline #20

Ugoku opened this issue Sep 17, 2019 · 0 comments
Assignees
@Ugoku
Labels
enhancement New feature or request

Comments

@Ugoku
Copy link
Member

Ugoku commented Sep 17, 2019

  • Make some errors easier to understand (eg. "Contact form contains invalid values" -> "Email is invalid")
  • Show less errors (i.e. don't show "contact form is empty" when you haven't selected products yet)
  • Show errors where they happen instead of at the very bottom
@Ugoku Ugoku self-assigned this Sep 24, 2019
@Ugoku Ugoku added the enhancement New feature or request label Sep 30, 2019
Ugoku added a commit that referenced this issue Oct 15, 2019
@Ugoku
Show discount form from the start
027b029 
Refs #20
Ugoku added a commit that referenced this issue Oct 15, 2019
@Ugoku
Better error messages for standalone contact forms
9199ab6 
Refs #20
This was referenced Oct 16, 2019
Merged
Merged
Ugoku added a commit that referenced this issue Oct 17, 2019
@Ugoku
Don't fetch available days when no products have been selected
ab0e746 
Refs #20
Ugoku added a commit that referenced this issue Dec 4, 2019
@Ugoku
Don't fetch available days when no products have been selected
f15cf21 
Refs #20
Ugoku added a commit that referenced this issue Dec 4, 2019
@Ugoku
Better error messages for standalone contact forms
0f21d9e 
Refs #20
Ugoku added a commit that referenced this issue Dec 6, 2019
@Ugoku
Process feedback
793e9b4 
Refs #20
Ugoku added a commit that referenced this issue Jan 8, 2020
@Ugoku
Don't fetch available days when no products have been selected
0968c62 
Refs #20
@Ugoku Ugoku mentioned this issue Jan 21, 2020
Merged
Ugoku added a commit that referenced this issue Jan 23, 2020
@Ugoku
IE styling fix
a22929a 
Refs #20
Ugoku added a commit that referenced this issue Jan 23, 2020
@Ugoku
Don't remove all errors if contact form is valid
9d480c7 
Refs #20
Ugoku added a commit that referenced this issue Jun 12, 2020
@Ugoku
Inline errors
02a4d3a 
Refs #20
Ugoku added a commit that referenced this issue Jun 12, 2020
@Ugoku
Add test for minimum amount error message & IE styling fix
8a895aa 
Refs #20
Ugoku added a commit that referenced this issue Jun 12, 2020
@Ugoku
Don't remove all errors if contact form is valid
4af1ade 
Refs #20
Ugoku added a commit that referenced this issue Dec 8, 2020
@Ugoku
Refactor to ease merging master
ef57ec3 
Refs #20
Ugoku added a commit that referenced this issue May 6, 2021
@Ugoku
Add test for minimum amount error message & IE styling fix
5559e1a 
Refs #20
Ugoku added a commit that referenced this issue May 6, 2021
@Ugoku
Don't remove all errors if contact form is valid
5eee8cf 
Refs #20
Ugoku added a commit that referenced this issue Oct 20, 2022
@Ugoku
Error message next to element
ddccc37 
Refs #20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ugoku Ugoku

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Ugoku