Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error trying to pass flowFrame to gs_cyto_data #372

Open
OuNao opened this issue Feb 21, 2022 · 1 comment
Open

Error trying to pass flowFrame to gs_cyto_data #372

OuNao opened this issue Feb 21, 2022 · 1 comment

Comments

@OuNao
Copy link

OuNao commented Feb 21, 2022

Hi,

The gs_cyto_data documentation show that a cytoset/flowSet/ncdfFlowSet can be used:

Description
Accessor method that gets or replaces the cytoset/flowSet/ncdfFlowSet object in a GatingSet or GatingHierarchy

But the code

data <- new("cytoset", pointer = get_cytoset(x@pointer))
use the pointer slot of the cytoset, so only cytoset is supported.

Maybe the documentation must be corrected and the code must test for cytoset.

Thanks.

@djhammill
Copy link
Contributor

Thanks for reporting this issue @OuNao.

The replacement method for gs_cyto_data() doesn't support flowFrame or cytoframe objects. Currently only cytoset replacement values are supported.

We still want to retain support for replacement using flowSet objects so I have submitted PR #383 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants